-
-
Notifications
You must be signed in to change notification settings - Fork 450
[PHP 8.4] fgetcsv() deprecated warning in three more files #4942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses PHP 8.4 compatibility by updating fgetcsv()
function calls to include the escape parameter, preventing deprecation warnings. The change affects three files that were missing from a previous similar update.
- Adds explicit escape parameter ('\') to
fgetcsv()
calls in three files - Ensures consistency with PHP 8.4 requirements for the
fgetcsv()
function signature - Completes the deprecation warning fixes started in PR #4297
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
lib/Varien/Io/File.php | Updated fgetcsv() call in streamReadCsv() method to include escape parameter |
app/code/core/Mage/Paypal/Model/Report/Settlement.php | Updated fgetcsv() call in CSV parsing loop to include escape parameter |
app/code/core/Mage/Dataflow/Model/Convert/Iterator/Http.php | Updated fgetcsv() call in file upload processing to include escape parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
We have to do one more step: ZF1-Future repository. @sreichel can you do it into your fork? I will approve the PR immediately. |
I'd suggest using "vendor patches". (and move all patches to this repo) |
It is a better approach. |
Fixed in #4891 . |
Related to PR #4297.
Three more files need to be updated.
PS - Credits to Copilot.