Skip to content

Conversation

addison74
Copy link
Contributor

Related to PR #4297.

Three more files need to be updated.

PS - Credits to Copilot.

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: lib/Varien Relates to lib/Varien Component: Dataflow Relates to Mage_Dataflow Component: lib/* Relates to lib/* labels Sep 26, 2025
@addison74 addison74 requested a review from Copilot September 26, 2025 18:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses PHP 8.4 compatibility by updating fgetcsv() function calls to include the escape parameter, preventing deprecation warnings. The change affects three files that were missing from a previous similar update.

  • Adds explicit escape parameter ('\') to fgetcsv() calls in three files
  • Ensures consistency with PHP 8.4 requirements for the fgetcsv() function signature
  • Completes the deprecation warning fixes started in PR #4297

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/Varien/Io/File.php Updated fgetcsv() call in streamReadCsv() method to include escape parameter
app/code/core/Mage/Paypal/Model/Report/Settlement.php Updated fgetcsv() call in CSV parsing loop to include escape parameter
app/code/core/Mage/Dataflow/Model/Convert/Iterator/Http.php Updated fgetcsv() call in file upload processing to include escape parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@kiatng kiatng merged commit 4ea0ef8 into OpenMage:main Sep 27, 2025
21 of 22 checks passed
@addison74
Copy link
Contributor Author

We have to do one more step: ZF1-Future repository.

@sreichel can you do it into your fork? I will approve the PR immediately.

@addison74 addison74 deleted the fix/php8.4-fgetcsv branch September 27, 2025 11:39
@sreichel
Copy link
Contributor

I'd suggest using "vendor patches".

(and move all patches to this repo)

@addison74
Copy link
Contributor Author

I'd suggest using "vendor patches".

(and move all patches to this repo)

It is a better approach.

@sreichel
Copy link
Contributor

Fixed in #4891 .

@sreichel sreichel added the chore label Sep 30, 2025
@sreichel sreichel added bug and removed chore labels Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Component: Dataflow Relates to Mage_Dataflow Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants