rename Aircraft.Wing.MOUNTING_TYPE to Aircraft.Wing.MOUNT_LOCATION #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause it is wing location on fuselage between 0 and 1.
jkirk5
approved these changes
Jan 16, 2025
ehariton
reviewed
Jan 22, 2025
| meta_data=_MetaData, | ||
| historical_name={"GASP": 'INGASP.HWING', "FLOPS": None, "LEAPS1": None}, | ||
| units='unitless', | ||
| desc='wing location on fuselage (0 = low wing, 1 = high wing)', | ||
| desc='wing mount location on fuselage (0 = low wing, 1 = high wing)', |
There was a problem hiding this comment.
This is a continuous variable. in the description we should add:
"Values between 0 and 1 are acceptable".
ehariton
approved these changes
Jan 22, 2025
jkirk5
reviewed
Jan 22, 2025
| @@ -5775,11 +5775,12 @@ | |||
| ) | |||
|
|
|||
| add_meta_data( | |||
| Aircraft.Wing.MOUNTING_TYPE, | |||
| Aircraft.Wing.MOUNT_LOCATION, | |||
jkirk5
reviewed
Jan 22, 2025
| meta_data=_MetaData, | ||
| historical_name={"GASP": 'INGASP.HWING', "FLOPS": None, "LEAPS1": None}, | ||
| units='unitless', | ||
| desc='wing location on fuselage (0 = low wing, 1 = high wing)', | ||
| desc='wing mount location on fuselage (0 = low wing, 1 = high wing)', |
There was a problem hiding this comment.
'vertical wing mount location....'
Mention that it is a continuous variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a very simple PR. The variable
Aircraft.Wing.MOUNTING_TYPEis the wing location on fuselage between 0 and 1. Rename it toAircraft.Wing.MOUNT_LOCATIONRelated Issues
Backwards incompatibilities
None
New Dependencies
None