Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin components clean (without sidebar) #1324

Merged

Conversation

hazeltonbw
Copy link
Contributor

Description

This PR removes the manage users button from the admin panel. This PR also includes changes to the admin panel as discussed in weekly meetings with @huss.

  1. Remove Manage Users button from Admin Panel
  2. Organize settings into their own categories, and give each a header to make it easy for the user to find the settings they want
  3. Change "Default site title" to "Site title"
  4. Rename Admin Panel to Admin Settings
  5. Update/add translations
  6. Small CSS tweaks

Partially Addresses #890

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

This PR will not be necessary if PR #1316 (Admin Settings w/ Sidebar change) gets merged as it changes the admin settings page completely.

@huss
Copy link
Member

huss commented Aug 1, 2024

This is to note that this PR should not be merged until PR #1306 is merged. This is due to the fact that the user button is (correctly) removed from this page in anticipation of the new user page/modals.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @hazeltonbw for this contribution. I've made a couple of comments to address but overall this looks good.

Moved graph section to the bottom of the page
Added margin-top to separate settings to make it more readable
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to address the comments. Overall, this looks good. I made a couple of comments that I think should not be hard to address.

@huss
Copy link
Member

huss commented Aug 4, 2024

Thanks to @hazeltonbw for the quick changes and taking the time to address everything instead of a future issue. This works as expected and is ready to merge.

@huss huss merged commit 76a4c3f into OpenEnergyDashboard:development Aug 4, 2024
3 checks passed
@huss huss mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants