-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin components clean (without sidebar) #1324
Admin components clean (without sidebar) #1324
Conversation
This is to note that this PR should not be merged until PR #1306 is merged. This is due to the fact that the user button is (correctly) removed from this page in anticipation of the new user page/modals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @hazeltonbw for this contribution. I've made a couple of comments to address but overall this looks good.
Moved graph section to the bottom of the page Added margin-top to separate settings to make it more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update to address the comments. Overall, this looks good. I made a couple of comments that I think should not be hard to address.
…sed. Move submit button to the right. Add border to mimic modal look.
Thanks to @hazeltonbw for the quick changes and taking the time to address everything instead of a future issue. This works as expected and is ready to merge. |
Description
This PR removes the manage users button from the admin panel. This PR also includes changes to the admin panel as discussed in weekly meetings with @huss.
Partially Addresses #890
Type of change
Checklist
Limitations
This PR will not be necessary if PR #1316 (Admin Settings w/ Sidebar change) gets merged as it changes the admin settings page completely.