Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal for admin user pages #890

Closed
huss opened this issue Apr 19, 2023 · 2 comments
Closed

modal for admin user pages #890

huss opened this issue Apr 19, 2023 · 2 comments
Labels
p-medium-priority reserved Expected to be assigned to developer by project so others should not work on without prior approval. t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 19, 2023

Is your feature request related to a problem? Please describe.

The user page is linked from the admin panel and does not have the look of the newer pages with modals.

Describe the solution you'd like

The look of these pages will change substantially to align with the new modal card look in OED. The top of the page will have a create button to create a user that is similar to the current create page but as a modal popup. A card for each user will have the email & role listed along with a button to edit the user. The modal that pops up will allow changes to the role and, unlike the current page, should allow for password change. There should also be a button to delete the user similar to the conversion page.

Another change is the "Users" button under "Manage:" on the admin page will be removed. In the dropdown menu in the top, right of the OED page, an additional option will be added that is labeled "Users" (only if an admin). This will take the admin to the user card page. The user card page should have an edit/create button with a cancel/discard as on other admin modal card pages along with similar logic/layout. The delete choice should confirm as on other pages.

A couple of other changes:

  • The translation in src/client/app/translations/data.ts for "Manage" is likely to be unused after these changes and can be removed in all languages.
  • There should be no default user role and the admin should be required to choose one.
  • The current page does not shift to the top as other pages. It is assumed this will be fix automatically when made similar to other pages.

Additional context

None

@huss huss added the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Apr 19, 2023
@huss huss added this to the 1.1 release milestone Apr 19, 2023
@huss huss mentioned this issue May 9, 2023
10 tasks
@huss huss removed the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Sep 26, 2023
@huss huss changed the title React hooks for admin user pages modal for admin user pages Apr 4, 2024
@huss huss added t-enhancement This issues tracks a potential improvement to the software p-medium-priority labels Apr 4, 2024
@huss
Copy link
Member Author

huss commented Apr 4, 2024

This issue was updated to only include the modal look as the other part was done earlier.

@huss huss added the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label May 31, 2024
@huss
Copy link
Member Author

huss commented Aug 9, 2024

This was fixed with PR #1306 and #1324 so closing.

@huss huss closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-medium-priority reserved Expected to be assigned to developer by project so others should not work on without prior approval. t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant