Skip to content

Fix for issue/141: cetl::get_if should should match only on a unbounded_variant #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025

Conversation

serges147
Copy link
Contributor

No description provided.

@serges147 serges147 self-assigned this Apr 10, 2025
pavel-kirienko
pavel-kirienko previously approved these changes Apr 11, 2025
@serges147 serges147 requested a review from Copilot April 14, 2025 08:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

cetlvast/suites/unittest/test_unbounded_variant.cpp:461

  • The expected value for 'src' was changed from '1 + 10' to '1'; please confirm that this behavior change is intentional.
EXPECT_THAT(get<test>(src).value_, 1);

include/cetl/cetl.hpp:132

  • The updated conditional for CETL_ENABLE_DEBUG_ASSERT now requires it to be truthy; please ensure that this change aligns with the intended behavior for debug assertions.
#if defined CETL_ENABLE_DEBUG_ASSERT && CETL_ENABLE_DEBUG_ASSERT

@serges147 serges147 requested a review from Copilot April 14, 2025 08:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@serges147 serges147 marked this pull request as ready for review April 14, 2025 08:18
@serges147 serges147 requested a review from thirtytwobits April 14, 2025 08:33
@serges147 serges147 merged commit b02ce3f into main Apr 15, 2025
58 checks passed
@serges147 serges147 deleted the issue/141_ub_get branch April 15, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants