-
Notifications
You must be signed in to change notification settings - Fork 3
Fix for issue/141: cetl::get_if
should should match only on a unbounded_variant
#185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
cetlvast/suites/unittest/test_unbounded_variant.cpp:461
- The expected value for 'src' was changed from '1 + 10' to '1'; please confirm that this behavior change is intentional.
EXPECT_THAT(get<test>(src).value_, 1);
include/cetl/cetl.hpp:132
- The updated conditional for CETL_ENABLE_DEBUG_ASSERT now requires it to be truthy; please ensure that this change aligns with the intended behavior for debug assertions.
#if defined CETL_ENABLE_DEBUG_ASSERT && CETL_ENABLE_DEBUG_ASSERT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
|
No description provided.