-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#810 challenge 42: Created a settings.xml to connect to an imaginary Nexus repo #1034
#810 challenge 42: Created a settings.xml to connect to an imaginary Nexus repo #1034
Conversation
Hi @divyanshuagarwal-23 can you please add the challenge code itself as well? having only the isolated XML will not do a lot without the challenge itself. Please have a look at https://github.com/OWASP/wrongsecrets/blob/master/CONTRIBUTING.md on how to add a challenge . |
<repository> | ||
<id>central</id> | ||
<url>http://central</url> | ||
<releases> | ||
<enabled>true</enabled> | ||
</releases> | ||
<snapshots> | ||
<enabled>true</enabled> | ||
</snapshots> | ||
</repository> |
Check failure
Code scanning / CodeQL
Failure to use HTTPS or SFTP URL in Maven artifact upload/download High
<pluginRepository> | ||
<id>central</id> | ||
<url>http://central</url> | ||
<releases> | ||
<enabled>true</enabled> | ||
</releases> | ||
<snapshots> | ||
<enabled>true</enabled> | ||
</snapshots> | ||
</pluginRepository> |
Check failure
Code scanning / CodeQL
Failure to use HTTPS or SFTP URL in Maven artifact upload/download High
Sure, working on it |
Hello @commjoen I have added the challenge as well, please review all the changes now |
Can you please refactor your challenge to number 42? 41 has been merged and your changes override the current challenge 41 instead of creating a new one. |
…edentials # Conflicts: # src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge42.java
@commjoen done, I have updated the challenge |
Uhoh, it looks like your deleting challenge41 now and partially overwrite.. Can we do something instead please?
|
Closing this in favor of https://github.com/OWASP/wrongsecrets/pull/1046/files . Thank you! |
What kind of changes does this PR include?
-Fixes
Description
As per #810 task one was to Create a settings.xml to connect to an imaginary Nexus repo,
I have created the settings.xml file for the same
and have created a challenge reading the credential
Relations
closes #810
References
issue: #810
took ref from: https://github.com/sonatype/nexus-book-examples/blob/master/maven/settings/settings.xml