Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#671 Added index column to Admin/ModuleManage/GetProgress table #688

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

#671 Added index column to Admin/ModuleManage/GetProgress table #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/dbProcs/Getter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,6 +1932,9 @@ public static String getProgress(String applicationRoot, String classId) {
if (resultSet.getString(1) != null) {
result +=
"<tr><td>"
+ resultAmount
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to break the code style, if you could fix the indentation I think it should be okay and the test should pass.

You can run this check in your IDE (depends on which one you're using) to verify. Please see https://github.com/OWASP/SecurityShepherd/blob/dev/CONTRIBUTING.md

+ // Output the user
"</td><td>"
+ Encode.forHtml(resultSet.getString(1))
+ // Output their progress
"</td><td><div style='background-color: #A878EF; heigth: 25px; width: "
Expand All @@ -1946,7 +1949,7 @@ public static String getProgress(String applicationRoot, String classId) {
}
}
if (resultAmount > 0) {
result = "<table><tr><th>Player</th><th>Progress</th></tr>" + result + "</table>";
result = "<table><tr><th>#</th><th>Player</th><th>Progress</th></tr>" + result + "</table>";
} else {
result = new String();
}
Expand Down