#671 Added index column to Admin/ModuleManage/GetProgress table #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismisepaul
requested changes
Aug 1, 2022
| @@ -1932,6 +1932,9 @@ public static String getProgress(String applicationRoot, String classId) { | |||
| if (resultSet.getString(1) != null) { | |||
| result += | |||
| "<tr><td>" | |||
| + resultAmount | |||
There was a problem hiding this comment.
This seem to break the code style, if you could fix the indentation I think it should be okay and the test should pass.
You can run this check in your IDE (depends on which one you're using) to verify. Please see https://github.com/OWASP/SecurityShepherd/blob/dev/CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on what I read Contributing to Shepherd Code, I'm not sure if I'm submitting this to the right branch or not. If it's incorrect please let me know and I can adjust.