Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: adds flow integer keywords #9463

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6164

Describe changes:

  • detect: adds flow.pkts_toclient keyword

OISF/suricata-verify#1267

SV_BRANCH=pr/1267

#9416 rebased without merged commits from other branches

Ticket: OISF#6164

flow.pkts_toclient
flow.pkts_toserver
flow.bytes_toclient
flow.bytes_toserver
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #9463 (500c8bc) into master (2b57179) will decrease coverage by 0.03%.
The diff coverage is 70.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9463      +/-   ##
==========================================
- Coverage   82.18%   82.16%   -0.03%     
==========================================
  Files         968      969       +1     
  Lines      274199   274353     +154     
==========================================
+ Hits       225363   225413      +50     
- Misses      48836    48940     +104     
Flag Coverage Δ
fuzzcorpus 64.06% <25.97%> (-0.04%) ⬇️
suricata-verify 60.86% <70.12%> (-0.05%) ⬇️
unittests 62.86% <25.97%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OISF).

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 15867

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look good, SV tests added look good too.

@victorjulien victorjulien added this to the 8.0 milestone Nov 16, 2023
@victorjulien
Copy link
Member

Merged in #9816, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants