detect: adds flow integer keywords #9416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: OISF#6164 flow.pkts_toclient flow.pkts_toserver flow.bytes_toclient flow.bytes_toserver
cf https://docs.rs/bitflags/latest/bitflags/#zero-bit-flags As warned by clippy 1.72.0
|
Information: QA ran without warnings. Pipeline 15775 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9416 +/- ##
==========================================
- Coverage 82.17% 82.13% -0.05%
==========================================
Files 968 969 +1
Lines 274198 274353 +155
==========================================
+ Hits 225331 225341 +10
- Misses 48867 49012 +145
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 15777 |
Closed
|
The documentation change looks good to me. |
Oops, from another PR, they were merged Now #9463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6164
Describe changes:
OISF/suricata-verify#1267
#9095 rebased to erase the status as changes requested and continue the debate
What do you want as an explanation ?
Doing git log --oneline | grep keyw , I see the latest added keyword is commit 9cb06d4 which does not have any more explanation than adding a keyword + reference to the redmine ticket...
Not obviously.
I think this would require to grow the size of the union PrefilterPacketHeaderValue (which may have perf impacts)
Any better ideas ?