Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/692/20250116/v1 #12413

Merged
merged 12 commits into from
Jan 17, 2025
Merged

next/692/20250116/v1 #12413

merged 12 commits into from
Jan 17, 2025

Conversation

victorjulien
Copy link
Member

@catenacyber @AkakiAlice
ldap: update ldap-parser crate
770a759 
so that we can implement abandon request support

Ticket: OISF#7477
@catenacyber @AkakiAlice
ldap: implement abandon request
edfe0cc 
Ticket: OISF#7477
@catenacyber @victorjulien
http: aliases for htp statuses
99ab3f7 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp server personalities
b482ae3 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp flags
fcfc10c 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp auths
604b625 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp methods
a4479c0 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp stream states
ef13394 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp protocol versions
8c61224 
In preparation of libhtp rust
@catenacyber @victorjulien
http: aliases for htp progresses
5ee6e7c 
In preparation of libhtp rust
@catenacyber @victorjulien
rust: remove unneeded mut for tx in loggers
af4e1e8 
Loggers do not change transactions, they read only.
@catenacyber @victorjulien
rust: remove unneeded mut for tx in detect
8f6795d 
Detection does not change transactions, it reads only.
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.90164% with 43 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (078c646) to head (8f6795d).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12413      +/-   ##
==========================================
- Coverage   80.63%   80.63%   -0.01%     
==========================================
  Files         917      918       +1     
  Lines      258687   258696       +9     
==========================================
- Hits       208601   208598       -3     
- Misses      50086    50098      +12
Flag Coverage Δ
fuzzcorpus 56.81% <68.31%> (+<0.01%) ⬆️
livemode 19.40% <25.92%> (+<0.01%) ⬆️
pcap 44.30% <66.25%> (+0.03%) ⬆️
suricata-verify 63.23% <80.74%> (+<0.01%) ⬆️
unittests 58.52% <63.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

jasonish
jasonish approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging looks OK.

@victorjulien victorjulien merged commit 8f6795d into OISF:master Jan 17, 2025
60 checks passed
This was referenced Jan 17, 2025
Merged
Closed
Closed
@victorjulien victorjulien deleted the next/692/20250116/v1 branch January 17, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @jasonish @catenacyber