Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: prepare libhtp-rs #12407

Closed
wants to merge 8 commits into from
Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/2696

Describe changes:

  • prepare libhtp-rs by defining aliases for the new values used by libhtp-rs

This allow to go one small step further

The big libhtp-rs commit will remove app-layer-htp-libhtp.h which defines these aliases

#12400 will need ro be rebased after this (with a smaller commit message and diff)

I will do a next PR like that for opaque accessors as well

In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 85.77982% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (078c646) to head (4f4dcc0).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12407      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.02%     
==========================================
  Files         917      918       +1     
  Lines      258687   258717      +30     
==========================================
- Hits       208601   208594       -7     
- Misses      50086    50123      +37     
Flag Coverage Δ
fuzzcorpus 56.81% <72.28%> (+<0.01%) ⬆️
livemode 19.40% <34.23%> (+<0.01%) ⬆️
pcap 44.25% <78.26%> (-0.01%) ⬇️
suricata-verify 63.23% <78.26%> (+<0.01%) ⬆️
unittests 58.51% <80.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Jan 16, 2025
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24231

@victorjulien
Copy link
Member

Merged in #12413, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants