Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: add initial unittests for DPDK codebase v7 #12395

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+490 −23
Open

dpdk: add initial unittests for DPDK codebase v7 #12395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d264857
dpdk: transform static variable to function-guarded global variable
Apr 7, 2024
64fbb56
dpdk: fix the CPU exclude logic
Apr 7, 2024
79b44cb
util-device: reset the device list after cleanup
Apr 7, 2024
9eb4a26
unittests: add skip directive to skip over unsupported unit tests
Apr 7, 2024
45edc56
dpdk: test mempool cache and threading assignment
Jan 13, 2025
5a6c501
github-ci: expand unit test coverage with DPDK tests
Jan 13, 2025
5f01c72
dpdk: supress a warning of the bond function
Sep 8, 2024
0cff665
github-ci: bump up DPDK versions in the build test
Nov 3, 2024
5cd0094
github-ci: build-test DPDK v23.11.x and v24.11.x
Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,7 @@ jobs:
ccache \
clang \
diffutils \
dpdk-devel \
file-devel \
gcc \
gcc-c++ \
Expand All @@ -809,6 +810,7 @@ jobs:
lz4-devel \
make \
parallel \
numactl-devel \
pcre2-devel \
pkgconfig \
python \
Expand All @@ -829,7 +831,7 @@ jobs:
- run: CC="clang" CFLAGS="$DEFAULT_CFLAGS -Wshadow" ./configure --disable-shared
- run: make check
- run: make distclean
- run: CC="clang" CFLAGS="$DEFAULT_CFLAGS -Wshadow -fsanitize=address -fno-omit-frame-pointer" ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
- run: CC="clang" CFLAGS="$DEFAULT_CFLAGS -Wshadow -fsanitize=address -fno-omit-frame-pointer" ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue --enable-dpdk
env:
LDFLAGS: "-fsanitize=address"
ac_cv_func_realloc_0_nonnull: "yes"
Expand Down Expand Up @@ -884,6 +886,7 @@ jobs:
cbindgen \
ccache \
diffutils \
dpdk-devel \
file-devel \
gcc \
gcc-c++ \
Expand All @@ -904,6 +907,7 @@ jobs:
libtool \
lz4-devel \
make \
numactl-devel \
pcre2-devel \
pkgconfig \
python3-yaml \
Expand All @@ -920,7 +924,7 @@ jobs:
- run: tar xf prep/libhtp.tar.gz
- run: tar xf prep/suricata-update.tar.gz
- run: ./autogen.sh
- run: ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
- run: ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue --enable-dpdk
env:
CFLAGS: "${{ env.DEFAULT_CFLAGS }} -Wshadow -fsanitize=address -fno-omit-frame-pointer"
LDFLAGS: "-fsanitize=address"
Expand Down Expand Up @@ -982,6 +986,7 @@ jobs:
ccache \
clang \
diffutils \
dpdk-devel \
file-devel \
gcc \
gcc-c++ \
Expand All @@ -1004,6 +1009,7 @@ jobs:
libtool \
lz4-devel \
make \
numactl-devel \
pcre2-devel \
pkgconfig \
python3-yaml \
Expand All @@ -1020,7 +1026,7 @@ jobs:
- run: tar xf prep/libhtp.tar.gz
- run: tar xf prep/suricata-update.tar.gz
- run: ./autogen.sh
- run: CC="clang" CFLAGS="$DEFAULT_CFLAGS -Wshadow -fsanitize=address -fno-omit-frame-pointer" ./configure --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
- run: CC="clang" CFLAGS="$DEFAULT_CFLAGS -Wshadow -fsanitize=address -fno-omit-frame-pointer" ./configure --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue --enable-dpdk
env:
LDFLAGS: "-fsanitize=address"
ac_cv_func_realloc_0_nonnull: "yes"
Expand Down Expand Up @@ -1075,6 +1081,7 @@ jobs:
cbindgen \
ccache \
diffutils \
dpdk-devel \
file-devel \
gcc \
gcc-c++ \
Expand All @@ -1095,6 +1102,7 @@ jobs:
libtool \
lz4-devel \
make \
numactl-devel \
pcre2-devel \
pkgconfig \
python3-yaml \
Expand All @@ -1111,7 +1119,7 @@ jobs:
- run: tar xf prep/libhtp.tar.gz
- run: tar xf prep/suricata-update.tar.gz
- run: ./autogen.sh
- run: ./configure --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
- run: ./configure --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue --enable-dpdk
env:
CFLAGS: "${{ env.DEFAULT_CFLAGS }} -Wshadow -fsanitize=address -fno-omit-frame-pointer"
LDFLAGS: "-fsanitize=address"
Expand Down Expand Up @@ -1160,6 +1168,7 @@ jobs:
ccache \
clang \
diffutils \
dpdk-devel \
file-devel \
gcc \
gcc-c++ \
Expand All @@ -1180,6 +1189,7 @@ jobs:
libtool \
lz4-devel \
make \
numactl-devel \
pcre2-devel \
pkgconfig \
python3-yaml \
Expand All @@ -1204,7 +1214,7 @@ jobs:
- run: sudo -u suricata -s ./autogen.sh
working-directory: /home/suricata/suricata

- run: sudo -u suricata -s env PATH="/home/suricata/.cargo/bin:$PATH" ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
- run: sudo -u suricata -s env PATH="/home/suricata/.cargo/bin:$PATH" ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue --enable-dpdk
working-directory: /home/suricata/suricata
env:
ac_cv_func_realloc_0_nonnull: "yes"
Expand Down Expand Up @@ -1453,6 +1463,7 @@ jobs:
automake \
clang-14 \
curl \
dpdk-dev \
git \
jq \
libtool \
Expand Down Expand Up @@ -1496,7 +1507,7 @@ jobs:
- run: tar xf prep/libhtp.tar.gz
- uses: ./.github/actions/install-cbindgen
- run: ./autogen.sh
- run: ./configure --enable-warnings --disable-shared --enable-unittests
- run: ./configure --enable-warnings --disable-shared --enable-unittests --enable-dpdk
env:
CC: "clang-14"
CXX: "clang++-14"
Expand Down Expand Up @@ -2539,7 +2550,7 @@ jobs:
needs: [ prepare-deps, prepare-cbindgen ]
strategy:
matrix:
dpdk_version: [ 22.11.4, 21.11.6, 20.11.10, 19.11.14 ]
dpdk_version: [ 24.11.1, 23.11.3, 22.11.7, 21.11.9, 20.11.10, 19.11.14 ]
steps:

# Cache Rust stuff.
Expand Down Expand Up @@ -2926,6 +2937,7 @@ jobs:
autoconf \
build-essential \
ccache \
dpdk-dev \
curl \
git \
jq \
Expand All @@ -2937,6 +2949,7 @@ jobs:
libcap-ng-dev \
libcap-ng0 \
libmagic-dev \
libnuma-dev \
libjansson-dev \
libgeoip-dev \
libhiredis-dev \
Expand Down Expand Up @@ -2966,7 +2979,7 @@ jobs:
- run: tar xf prep/suricata-update.tar.gz
- uses: ./.github/actions/install-cbindgen
- run: ./autogen.sh
- run: CFLAGS="${DEFAULT_CFLAGS}" ./configure --enable-warnings --enable-unittests --enable-fuzztargets --enable-ebpf --enable-ebpf-build
- run: CFLAGS="${DEFAULT_CFLAGS}" ./configure --enable-warnings --enable-unittests --enable-fuzztargets --enable-ebpf --enable-ebpf-build --enable-dpdk
- run: make -j ${{ env.CPUS }}
- run: make check
- run: tar xf prep/suricata-verify.tar.gz
Expand Down
Loading
Loading