dpdk: add initial unittests for DPDK codebase v7 #12395
Open
+490
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 13, 2025 12:55
To better control the values within the variables and to prepare for the follow-up unit tests, the variable was moved into global scope and should accessed only by functions. This allows reinstantination of the variable value - needed for unit tests.
The function would incorrectly perform XOR operation. While it worked when the worker cores were occupying all cores, it is still not correct operation. The example might be when a core would be affined to only management and not worker threads. With the XOR operation it would set affinity to also worker set. (1 XOR 0 -> 1 where in fact the desired outcome is 0)
For the upcoming changes, skipping a unit test might be beneficial when testing a function that retrieves hardware data. This can e.g. depend on the number of CPU cores and systems that does not meet the required test criteria will need to omit the tests. The tests should always target minimal system requirements
The commit adds unit tests for mempool cache calculation. The DPDK mempool cache can be automatically calculated from the size of the mempool. The commit also adds unit tests for automatic thread distribution when multiple interfaces are present and when there is a possible overlap with management threads. Ticket: 6927
DPDK Bonding API has been changed in DPDK version 23.11 where the old *slave* API was marked as deprecated and the new *member* API was marked as experimental. This was unfortunately executed by marking both API variants at the same time. The deprecated version is removed from the follow up versions while the experimental version will become stable in the next DPDK releases. This is based on a policy in DPDK where an API change needs to merged in main for 1 stable release before removing the experimental flag. In DPDK 24.11 this has been fixed and warning supression is not added. Ticket: 7009
Ticket: 6382
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12395 +/- ##
==========================================
- Coverage 82.46% 80.63% -1.84%
==========================================
Files 914 915 +1
Lines 258316 258736 +420
==========================================
- Hits 213030 208635 -4395
- Misses 45286 50101 +4815
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of: #12083
Redmine tickets:
The PR is adding unit tests tailored to verify CPU threading logic and the automatic calculation of mempool cache of the interface.
Describe changes:
v7:
v6:
v5:
v4
v3
v2
v1