Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Add linktype name #11279

Closed
wants to merge 1 commit into from
Closed

output: Add linktype name #11279

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11277

Issue: 6954

This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954

Describe changes:

  • Include the linktype name alongside linktype
  • Update the schema with linktype_name

Updates:

  • Rebased sv branch

Provide values to any of the below to override the defaults.

SV_BRANCH=OISF/suricata-verify#1853

Issue: 6954

This commit adds the linktype name to the output stream. The name is
determined from the pcap utility function pcap_datalink_val_to_name
@jlucovsky jlucovsky requested review from victorjulien and a team as code owners June 9, 2024 12:07
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21024

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work :-)

Personally, I would still not log linktype_name if dl_name == NULL, but ok this was also

  • CI : 🟢
  • Code : good for me
  • Commits segmentation : one commit is enough
  • Commit messages : good enough for me
  • Git ID set : looks fine for me
  • CLA : you already contributed :-p
  • Doc update : ok in json schema
  • Redmine ticket : ok
  • Rustfmt : no rust
  • Tests : SV ok
  • Dependencies added: none

@victorjulien
Copy link
Member

@jlucovsky this is blocked by OISF/suricata-verify#1853 (comment)

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more testing / more thorough SV tests.

@jufajardini
Copy link
Contributor

Can this be closed in favor of #11584?

@victorjulien
Copy link
Member

replaced by #11584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants