Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Add linktype name #11277

Closed
wants to merge 1 commit into from
Closed

output: Add linktype name #11277

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11207

Issue: 6954

This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954

Describe changes:

  • Include the linktype name alongside linktype
  • Update the schema with linktype_name

Provide values to any of the below to override the defaults.

SV_BRANCH=OISF/suricata-verify#1853

Issue: 6954

This commit adds the linktype name to the output stream. The name is
determined from the pcap utility function pcap_datalink_val_to_name
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (0d267e2) to head (d411edf).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11277      +/-   ##
==========================================
- Coverage   82.99%   79.01%   -3.98%     
==========================================
  Files         942      961      +19     
  Lines      249353   251524    +2171     
==========================================
- Hits       206952   198751    -8201     
- Misses      42401    52773   +10372     
Flag Coverage Δ
fuzzcorpus 60.30% <66.66%> (-0.80%) ⬇️
livemode 18.68% <0.00%> (-0.11%) ⬇️
pcap 43.69% <0.00%> (-0.63%) ⬇️
suricata-verify ?
unittests 59.95% <0.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21018

@jlucovsky
Copy link
Contributor Author

Continued in #11279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants