Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify bypass behavior under different traffic profiles v3 #2114

Closed
wants to merge 2 commits into from
Closed

Verify bypass behavior under different traffic profiles v3 #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab1211
ssh: adjust to SSH bypass behavior change for 8.0.0 change
lukashino Sep 19, 2024
f5205f2
bypass: verify bypass behavior
lukashino Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/bypass-depth-disabled/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Test Description

Tests that no traffic is bypassed even with minimal reassembly depth

## PCAP

Source: https://wiki.wireshark.org/SampleCaptures
File: dump.pcapng

## Related issues

Created with a work to decouple stream.bypass setting from TLS encrypted bypass.
https://redmine.openinfosecfoundation.org/issues/6788
Binary file added tests/bypass-depth-disabled/input.pcap
View file
Open in desktop
Binary file not shown.
18 changes: 18 additions & 0 deletions tests/bypass-depth-disabled/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
requires:
min-version: 7

args:
- -k none
- --set app-layer.protocols.tls.encryption-handling=full
- --set app-layer.protocols.ssh.encryption-handling=full
- --set stream.reassembly.depth=1
- --set stream.bypass=false

checks:
- filter:
count: 1
match:
event_type: stats
- stats:
flow_bypassed.local_pkts: 0
flow_bypassed.local_bytes: 0
13 changes: 13 additions & 0 deletions tests/bypass-depth-enabled/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Test Description

Tests that traffic is bypassed after reaching the reassembly depth

## PCAP

Source: https://wiki.wireshark.org/SampleCaptures
File: dump.pcapng

## Related issues

Created with a work to decouple stream.bypass setting from TLS encrypted bypass.
https://redmine.openinfosecfoundation.org/issues/6788
Binary file added tests/bypass-depth-enabled/input.pcap
View file
Open in desktop
Binary file not shown.
18 changes: 18 additions & 0 deletions tests/bypass-depth-enabled/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
requires:
min-version: 7

args:
- -k none
- --set app-layer.protocols.tls.encryption-handling=full
- --set app-layer.protocols.ssh.encryption-handling=full
- --set stream.reassembly.depth=1
- --set stream.bypass=true

checks:
- filter:
count: 1
match:
event_type: stats
- stats:
flow_bypassed.local_pkts: 11
flow_bypassed.local_bytes: 6126
14 changes: 14 additions & 0 deletions tests/bypass-ssh-enabled/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Test Description

Tests that the encrypted part of the SSH traffic is bypassed but it should not
bypass based on the depth

## PCAP

Source: https://www.cloudshark.org/captures/9b72eb8febf9
File: ssh-server-client.pcapng

## Related issues

Created with a work to decouple stream.bypass setting from TLS encrypted bypass.
https://redmine.openinfosecfoundation.org/issues/6788
Binary file added tests/bypass-ssh-enabled/input.pcap
View file
Open in desktop
Binary file not shown.
18 changes: 18 additions & 0 deletions tests/bypass-ssh-enabled/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
requires:
min-version: 8

args:
- -k none
- --set app-layer.protocols.tls.encryption-handling=full
- --set app-layer.protocols.ssh.encryption-handling=bypass
- --set stream.reassembly.depth=1MB
- --set stream.bypass=false

checks:
- filter:
count: 1
match:
event_type: stats
- stats:
flow_bypassed.local_pkts: 45
flow_bypassed.local_bytes: 3972
13 changes: 13 additions & 0 deletions tests/bypass-tls-disabled/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Test Description

Tests that no traffic is bypassed with disabled bypass settings

## PCAP

Source: https://wiki.wireshark.org/SampleCaptures
File: dump.pcapng

## Related issues

Created with a work to decouple stream.bypass setting from TLS encrypted bypass.
https://redmine.openinfosecfoundation.org/issues/6788
Binary file added tests/bypass-tls-disabled/input.pcap
View file
Open in desktop
Binary file not shown.
18 changes: 18 additions & 0 deletions tests/bypass-tls-disabled/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
requires:
min-version: 7

args:
- -k none
- --set app-layer.protocols.tls.encryption-handling=full
- --set app-layer.protocols.ssh.encryption-handling=full
- --set stream.reassembly.depth=1MB
- --set stream.bypass=false

checks:
- filter:
count: 1
match:
event_type: stats
- stats:
flow_bypassed.local_pkts: 0
flow_bypassed.local_bytes: 0
14 changes: 14 additions & 0 deletions tests/bypass-tls-enabled/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Test Description

Tests that the encrypted part of the traffic is bypassed but it should not
bypass based on the depth

## PCAP

Source: https://wiki.wireshark.org/SampleCaptures
File: dump.pcapng

## Related issues

Created with a work to decouple stream.bypass setting from TLS encrypted bypass.
https://redmine.openinfosecfoundation.org/issues/6788
Binary file added tests/bypass-tls-enabled/input.pcap
View file
Open in desktop
Binary file not shown.
18 changes: 18 additions & 0 deletions tests/bypass-tls-enabled/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
requires:
min-version: 8

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it reusing a pcap ?

args:
- -k none
- --set app-layer.protocols.tls.encryption-handling=bypass
- --set app-layer.protocols.ssh.encryption-handling=full
- --set stream.reassembly.depth=1MB
- --set stream.bypass=false

checks:
- filter:
count: 1
match:
event_type: stats
- stats:
flow_bypassed.local_pkts: 4
flow_bypassed.local_bytes: 275
2 changes: 1 addition & 1 deletion tests/ssh-hassh/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ features:
- RUST

args:
- -k none --set stream.bypass=yes
- -k none --set stream.bypass=yes --set app-layer.protocols.ssh.encryption-handling=bypass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behavior change

  • Encrypted SSH traffic bypass is now independently controlled through
    app-layer.protocols.ssh.encryption-handling setting. The setting can either
    be bypass, default or full.
    To retain the previous behavior of encrypted traffic bypass
    combined with stream depth bypass, set
    app-layer.protocols.ssh.encryption-handling to bypass (while also
    setting app-layer.protocols.tls.encryption-handling to bypass and
    stream.bypass to true).

Previously SSH was bypassed after the session turned encrypted, now we need to be more explicit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re

Previously SSH was bypassed after the session turned encrypted, now we need to be more explicit.

So previously when the SSH session turned encrypted and stream bypass was allowed then it bypassed the flow. This was not related to reaching the stream depth but only to the session state.
Currently, you can replicate the behavior with setting encryption handling to bypass.


checks:
# Check that we have the following events in eve.json
Expand Down
Loading