Verify bypass behavior under different traffic profiles v3 #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6788
This was referenced Nov 3, 2024
catenacyber
reviewed
Dec 3, 2024
| @@ -4,7 +4,7 @@ features: | |||
| - RUST | |||
|
|
|||
| args: | |||
| - -k none --set stream.bypass=yes | |||
| - -k none --set stream.bypass=yes --set app-layer.protocols.ssh.encryption-handling=bypass | |||
There was a problem hiding this comment.
Why do we need this change ?
There was a problem hiding this comment.
behavior change
- Encrypted SSH traffic bypass is now independently controlled through
app-layer.protocols.ssh.encryption-handlingsetting. The setting can either
bebypass,defaultorfull.
To retain the previous behavior of encrypted traffic bypass
combined with stream depth bypass, set
app-layer.protocols.ssh.encryption-handlingtobypass(while also
settingapp-layer.protocols.tls.encryption-handlingtobypassand
stream.bypasstotrue).
Previously SSH was bypassed after the session turned encrypted, now we need to be more explicit.
There was a problem hiding this comment.
Re
Previously SSH was bypassed after the session turned encrypted, now we need to be more explicit.
So previously when the SSH session turned encrypted and stream bypass was allowed then it bypassed the flow. This was not related to reaching the stream depth but only to the session state.
Currently, you can replicate the behavior with setting encryption handling to bypass.
catenacyber
reviewed
Dec 3, 2024
| @@ -0,0 +1,18 @@ | |||
| requires: | |||
| min-version: 8 | |||
|
|
|||
There was a problem hiding this comment.
Is it reusing a pcap ?
|
cont in #2170 P's comment is mentioned in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2078
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6788
Note:
Describe changes:
v3: