Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add rule to check for tcp/ack - v2 #1430

Closed
wants to merge 1 commit into from
Closed

tests: add rule to check for tcp/ack - v2 #1430

wants to merge 1 commit into from

Conversation

0xEniola
Copy link
Contributor

Test for rule type for tcp-ack keyword.

Related to
Issue: #6354

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6354

Suricata PR: OISF/suricata#9644

Previous PR: #1423

@0xEniola
tests: add rule to check for tcp/ack
01615e7 
Related to
Issue: #6354
@0xEniola 0xEniola mentioned this pull request Oct 17, 2023
Closed
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 17, 2023
@inashivb inashivb added the needs rebase PR looks fine but needs a rebase label Oct 18, 2023
inashivb
inashivb requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @0xEniola ! Looking good now. :)
Please rebase your PR with the latest master and resubmit.

@0xEniola 0xEniola mentioned this pull request Oct 19, 2023
Closed
@0xEniola 0xEniola closed this Oct 19, 2023
@0xEniola 0xEniola deleted the sv-task-6354-v2 branch October 22, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb requested changes

Assignees
No one assigned
Labels
needs rebase PR looks fine but needs a rebase outreachy Contributions made by Outreachy applicants
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xEniola @inashivb @jufajardini