tests: add rule to check for tcp/ack - v3 #1432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to Issue: #6354
inashivb
added
requires suricata pr
Also, the suricata pr is present. |
We add that to ensure that we remember that this should only be merged once we have merged the Suricata counter-part, otherwise the SV tests would be failing! :) |
Ohhh! I see. Good to know 😊. |
jufajardini
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for rule type for tcp-ack keyword.
Related to
Issue: #6354
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6354
Suricata PR: OISF/suricata#9659
Previous PR: #1430