[FIX][9.0] travis: Add SASS #284
Conversation
|
Crap Travis is building this on 10.0 too. I'm now incredibly confused - The travis file clearly says v9. |
lasley
force-pushed
the
bugfix/9.0/sass
branch
from
5980601 to
f9dcf0b
Compare
|
Amending the commit did the trick. I'll keep in mind for future. Now back to troubleshooting the real issue |
lasley
force-pushed
the
bugfix/9.0/sass
branch
2 times, most recently
from
5d012df to
7fc1043
Compare
* Upgrade ruby version * Add `bootstrap-sass` dependency * Add `compass` dependency
* Remove v8 migrations * Remove duplicated http send in favor of pass * Fix broken test for exception handling
lasley
force-pushed
the
bugfix/9.0/sass
branch
from
3f27010 to
982398f
Compare
|
Alright this should be good assuming build passes. I'm still baffled why this error appeared out of nowhere, but I needed to update the Ruby version in Travis to support SASS, then add After that, I resolved the test issue in |
|
Now we're ping-ponging CIs here. Runbot is failing due to the use of the RVM command, which is by far the best way to upgrade Ruby on Travis. Version <2 Ruby is deprecated for We'll need to add this either to Travis2Docker or to the Docker base image for Runbot. I think the image, but I'll wait for response from Vauxoo in associated issue before randomly hacking about. |
|
Shouldn't we be using t2d at this point? |
|
Travis2docker is not activated yet for all repositories. I don't know if website is one of them. |
|
Website is one of them, and the issue is specific to T2D - although we would have the same issue if stock Runbot. I'm working on fixing the base Docker image, and should have something submitted by EOD today |
|
Seems like runbot went ❌ |
|
Runbot 🔴 was fixed in:
We just need to wait for updates noted in OCA/runbot-addons#105 (comment) then a rebuild will fix. |
| @@ -80,5 +80,5 @@ def website_logo(self, dbname=None, **kw): | |||
| image, filename=imgname, mtime=mtime) | |||
| return response | |||
| except Exception: | |||
| return http.send_file(placeholder(imgname)) | |||
| pass | |||
There was a problem hiding this comment.
Using pep-0020:
- Errors should never pass silently.
If there’s really nothing to do add a _logger.error
There was a problem hiding this comment.
Hmmm guess I need to re-read that one, but I agree this was bad. .error it is, there is indeed nothing to do because the end return handles it
|
Alright Runbot fixed, and green like @moylop260 noted. This is good for a merge I believe |
|
🎉 🎈 |
Possible fix to #282 and resubmit of #283, which was to the wrong branch.
Question still stands as to why this issue just popped up, and why it's not showing on v8 or v10.