runbot_travis2docker: does not seem to work on OCA runbot

[gurneyalex]

I probably got some configuration wrong.

I'm using docker 1.6.2 (from jessie-backports), the user running odoo is a member of the docker group (but odoo is not running inside docker).

Test repository is https://runbot.odoo-community.org/runbot/repo/github-com-vauxoo-dev-runbot-branch-remote-name-grp-feature2-232

Setup:

I get empty builds or skipped builds, docker ps says nothing, and docker images is also empty.

Weird line in the logs:

2016-11-07 16:23:12,856 4580 INFO openerp-oca-runbot openerp.addons.runbot_travis2docker.models.runbot_build: Dockerfile without TESTS=1 env. Skipping builds [3271674]

[gurneyalex]

@moylop260 your feedback is very welcome on this. Thanks for your help.

[moylop260]

What is your travisfile2dockerfile --version?

[lasley]

The Travis file needs to be upgraded to the new version. This error is saying there is no "TESTS=1" in the matrix, which is defaulted so doesn't hurt Travis.

Happens all the time on our instance, which is why you see me submitting new Travis files quite often. You can see the transition on our web repo. Skipped are all before merge of OCA/web#447 or OCA/web#448

Although @moylop260 comment maybe alludes to this being fixed in a newer T2D version?

[moylop260]

@gurneyalex
I'm using the following runbot.repo configuration:

It's building here:
http://runbot.vauxoo.com/runbot/repo/https-github-com-vauxoo-dev-runbot-branch-remote-name-grp-feature2-git-90

I don't see the url in the image of your first comment but could change it by:
https://github.com/vauxoo-dev/runbot_branch_remote_name_grp_feature2.git

NOTE: The docker version is too old this could get new errors by old bug but Its is other matter.

[moylop260]

@lasley
Thanks for the information.

For this case we are using a .travis.yml file upgraded:

https://github.com/vauxoo-dev/runbot_branch_remote_name_grp_feature2/blob/ac681dcb4cfcbb8df9c26ed8cadf8e4c837f21be/.travis.yml#L21-L27

[lasley]

Yup that Travis should definitely not be exhibiting this issue 😦

[gurneyalex]

@moylop260

$ bin/travisfile2dockerfile --version
travisfile2dockerfile 3.0.8

[moylop260]

@gurneyalex
Could you share me a screenshot of runbot.repo record but without edition mode, please? (To show the full url)

[moylop260]

@gurneyalex
The repository installed are:

• https://github.com/gurneyalex/runbot-addons/tree/9.0-OCA-installation
• https://github.com/gurneyalex/odoo-extra/tree/OCA-runbot

Right?

[gurneyalex]

@moylop260 I think the problem comes from gurneyalex/odoo-extra@92b578a which is installed on our instance : the screenshot shows the configured URL (without the https:// prefix which is added by that patch, and your addon expects a full URL.

[moylop260]

@gurneyalex Thanks for the information
Fix #106

[gurneyalex]

@moylop260 things seem to be better, cf.

https://runbot.odoo-community.org/runbot/repo/github-com-vauxoo-dev-runbot-branch-remote-name-grp-feature2-232

[gurneyalex]

@moylop260 at lease 1 build worked. Are the failures on the other branches expected ?

[moylop260]

Yeah, we have currently the following issue
OCA/maintainer-quality-tools#384 (Installing just base show that error)

Showing in travis too the same error:
travis-build-OCA/maintainer-quality-tools#384

Then it is not a runbot or travis2docker error. It is a MQT expected fail.

IMHO we are ready (We don't have real projects installing just base)

[moylop260]

We could use a "technical" real repository like as server-tools

I'm testing it from custom instance using all the patches and It is working fine:

[gurneyalex]

Yesterday I enabled docker builds for

• rma (5 instances running on docker at the moment)
• server-tools (7 instances)

[gurneyalex]

I just enabled

• account-financial-tools
• web
• website

For now all of them have the tests disabled (same for rma and server-tools).

cc @moylop260 @lasley

[lasley]

Hmmm looks like the new version isn't appending the log to DB. I admittedly haven't updated my Runbot since before the code sprint, so I haven't functionally tested our improvements outside of local. I'll update today and see what's wrong.

[lasley]

Fix is in #107 - seems my PEP8ing after test and before PR ended up changing the end result of the .format. My bad on that, I was going a lot of directions during the code sprint

[moylop260]

To see the logs we need a log.warning or a log.error into of a build.
But I don't found the first one with this log.

How are you checking this issue?

[moylop260]

I found a warning in a runbot build but is not enabled for docker.
The branch 8.0 of https://runbot.odoo-community.org/runbot/repo/github-com-oca-l10n-switzerland-125

@gurneyalex
Could you help us to enable it in this project in order to confirm a issue with the logs?

[gurneyalex]

added

• carrier-delivery
• product-*
• stock-*
• community-data
• l10n-switzeland (cc @moylop260 I triggered a rebuild of the 8.0 branch)

[moylop260]

I saw in stock-* project the following error (and fix): OCA/maintainer-quality-tools#386

[moylop260]

I saw in l10n-switzerland project the following error (and fix): Vauxoo/docker-odoo-image@3eaae03

(This change require run the following command in the oca server: `docker pull vauxoo/odoo-80-image-shippable-auto`)

TODO: Use the parameter --pull from runbot-addons to auto-pull the big image in each change.

[moylop260]

TODO: Use the parameter --pull from runbot-addons to auto-pull the big image in each change.

Fixed from #109

[lasley]

Gotta love the edge cases that crop up when launching at scale 😉

[lasley]

@gurneyalex - We made some changes that will resolve the issues we've been seeing. Edit: it may only be this issue now that I think about it

Would you mind doing a pip install git+https://github.com/Vauxoo/travis2docker.git to grab the new version of T2D that includes Vauxoo/travis2docker#77?

We'll also need to update the runbot addon to the new version merged in #109.

[gurneyalex]

I'm sorry I can't today. I'll try hard tomorrow.

[gurneyalex]

@lasley @moylop260 I've just updated the runbot as requested

[moylop260]

Thank you
T2d upgrade is required too
pip install git+https://github.com/Vauxoo/travis2docker.git
Please

[gurneyalex]

@moylop260 I did this. Running 99680477d329aee2e54b9cf512531479cd118920 (which is on 3.0.8).

[gurneyalex]

maybe I'm catching an outdated version. Can you make a 3.0.8 release and publish it on pypi ? It's way easier for me due to the way the runbot is deployed to use published documented versions rather than github heads.

[moylop260]

I'll do it
Thank you

[moylop260]

Someone is wrong
All builds are skipping
I'll check it

[moylop260]

With the following environment:

• runbot-addons

~/runbot-addons (9.0-OCA-installation)$ git log -r -2
commit 33e5a2abb43cbd24b738d79d18964de7c3f17997
Merge: 251dc63 092e6f8
Author: Alexandre Fayolle <[email protected]>
Date:   Wed Nov 23 15:01:53 2016 +0100

    Merge remote-tracking branch 'origin/9.0' into 9.0-OCA-installation

commit 092e6f889b252f82cc2abd1bfb87f6443a37bf5b
Merge: 8044166 b0a5635
Author: Pedro M. Baeza <[email protected]>
Date:   Mon Nov 21 18:30:03 2016 +0100

    Merge pull request #109 from vauxoo-dev/9.0-oca-pull-img-moy

    [REF] runbot_travis2docker: Auto pull image for long-term updates

• travis2docker

pip install --upgrade travis2docker==3.0.9
travisfile2dockerfile --version
travisfile2dockerfile 3.0.9

• Rebooting the odoo server.
• Pressing Rebuild button of the build https://github.com/vauxoo-dev/runbot_branch_remote_name_grp_feature2/tree/fast-travis

• Result:

It's not skipped

Do you have a logger error?

[moylop260]

@gurneyalex The odoo-extra have the patch of the https// applied yet, right? (I don't have other idea)

[moylop260]

@gurneyalex Tell me if I can help...

[gurneyalex]

I'm sorry I was away yesterday. I just updated the runbot. I'll monitor carefully the builds in the coming hours

[gurneyalex]

@moylop260 Things seem to be a bit better. My build on OCA/web#498 was correctly processed.

[lasley]

@gurneyalex - I rebuilt all of the website builds that were skipped, and we seem good to go. And in even better news, OCA/website#284 now works so that means the RVM install is working too!

[moylop260]

I saw in stock-* project the following error (and fix): OCA/maintainer-quality-tools#386

I rebuilt https://runbot.odoo-community.org/runbot/build/3273461 and now is working

I saw in l10n-switzerland project the following error (and fix): Vauxoo/docker-odoo-image@3eaae03

I rebuilt https://runbot.odoo-community.org/runbot/build/3273217 and now is working
(We have other unrelated error fixed here: OCA/l10n-switzerland#284)

[moylop260]

@gurneyalex
Could we enable travis2docker in other projects?

[gurneyalex]

@moylop260 I just enabled travis2docker on all projects.