-
-
Notifications
You must be signed in to change notification settings - Fork 488
[MIG] base_user_show_email: Migration to 19.0 #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Changes from all commits
7f5c671
b31ce30
f0be1a9
96b8113
a00d905
d6fd238
c09c1cc
8d397a8
12008ea
329d57a
8314564
2fcf1bb
b6c31cb
18bfd5b
c39f871
5000aca
e521cce
d758a63
91686b0
6a4e654
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| ==================== | ||
| Base User Show Email | ||
| ==================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:0bcc12b4e1b6e7c68e6252c2db5ff3e174bb9aab16229b623103bddcc9b6f818 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--auth-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/server-auth/tree/18.0/base_user_show_email | ||
| :alt: OCA/server-auth | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/server-auth-18-0/server-auth-18-0-base_user_show_email | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/server-auth&target_branch=18.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| In recent Odoo versions, the login field is tightly linked to the email | ||
| field (the field is displayed with an "Email" label, and it will | ||
| populate the email of the user if it contains an "@" character). | ||
|
|
||
| Yet for the users who uses a distinct login and email, this is | ||
| confusing. | ||
|
|
||
| The goal of this module is to untangle (a bit) these two fields. Here | ||
| are the changes: | ||
|
|
||
| - In the res.users tree view: | ||
|
|
||
| - Display the email field next to the login field | ||
|
|
||
| - Change the login layout to prompt for a "Login" instead of an "Email" | ||
| (compatible with the web_enterprise layout) | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-auth/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/server-auth/issues/new?body=module:%20base_user_show_email%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * Camptocamp | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - Patrick Tombez <[email protected]> | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/18.0/base_user_show_email>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Copyright 2019 Camptocamp | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| { | ||
| "name": "Base User Show Email", | ||
| "version": "19.0.1.0.0", | ||
| "category": "Tools", | ||
| "website": "https://github.com/OCA/server-auth", | ||
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "installable": True, | ||
| "application": False, | ||
| "summary": "Untangle user login and email", | ||
| "depends": ["base", "web"], | ||
| "data": ["views/res_users_view.xml", "views/login_layout.xml"], | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||||||||||||||
| # Translation of Odoo Server. | ||||||||||||||||||
| # This file contains the translation of the following modules: | ||||||||||||||||||
| # * base_user_show_email | ||||||||||||||||||
| # | ||||||||||||||||||
| msgid "" | ||||||||||||||||||
| msgstr "" | ||||||||||||||||||
| "Project-Id-Version: Odoo Server 18.0\n" | ||||||||||||||||||
|
||||||||||||||||||
| "Project-Id-Version: Odoo Server 18.0\n" | |
| "Project-Id-Version: Odoo Server 19.0\n" |
Copilot
AI
Nov 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation files reference a view base_user_show_email.user_email_form (lines 17, 23), but this view does not exist in the module's XML files. The module's DESCRIPTION.md mentions form view modifications, but only tree view (res_users_view.xml) and login layout (login_layout.xml) files are included. Either:
- The form view file is missing from this migration and needs to be added, or
- These translation entries are outdated and should be removed
This should be investigated and resolved to ensure the module works correctly.
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form | |
| msgid "Email Address" | |
| msgstr "" | |
| #. module: base_user_show_email | |
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.login | |
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form | |
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.login |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||||||||||||||||||||||||
| # Translation of Odoo Server. | ||||||||||||||||||||||||||||
| # This file contains the translation of the following modules: | ||||||||||||||||||||||||||||
| # * base_user_show_email | ||||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||||
| msgid "" | ||||||||||||||||||||||||||||
| msgstr "" | ||||||||||||||||||||||||||||
| "Project-Id-Version: Odoo Server 16.0\n" | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
| "Project-Id-Version: Odoo Server 16.0\n" | |
| "Project-Id-Version: Odoo Server 19.0\n" |
Copilot
AI
Nov 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation file references a view base_user_show_email.user_email_form (lines 20, 23, 26, 27), but this view does not exist in the module's XML files. Either this form view is missing from the migration, or these translation entries are outdated and should be removed. This should be synchronized with the actual module implementation.
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form | |
| msgid "Email Address" | |
| msgstr "Indirizzo e-mail" | |
| #. module: base_user_show_email | |
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.login | |
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form | |
| #. module: base_user_show_email | |
| #: model_terms:ir.ui.view,arch_db:base_user_show_email.login |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Patrick Tombez \<<[email protected]>\> |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,19 @@ | ||||||||
| In recent Odoo versions, the login field is tightly linked to the email | ||||||||
| field (the field is displayed with an "Email" label, and it will | ||||||||
| populate the email of the user if it contains an "@" character). | ||||||||
|
|
||||||||
| Yet for the users who uses a distinct login and email, this is | ||||||||
|
||||||||
| Yet for the users who uses a distinct login and email, this is | |
| Yet for the users who use a distinct login and email, this is |
Copilot
AI
Nov 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DESCRIPTION.md mentions changes to "the res.users form view" (lines 11-13), but the README.rst (which is generated from the description) omits this section and only mentions the tree view (line 41) and login layout (line 45). Additionally, the translation files reference base_user_show_email.user_email_form view, but no form view is included in the views directory. Either:
- A form view file is missing from this migration, or
- The DESCRIPTION.md is outdated and should be updated to remove the form view references
This inconsistency should be resolved to ensure the module description matches the actual implementation.
| - In the res.users form view: | |
| - Display a "Login" label instead of "Email" on the login field | |
| - Show the currently invisible email field and its label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version references in this file still point to 18.0 but should be updated to 19.0 for this migration. The following lines need updating: