[MIG] base_user_show_email: Migration to 19.0 #867

augusto-weiss · 2025-11-20T18:56:15Z

No description provided.

Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-16.0/server-auth-16.0-base_user_show_email Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-base_user_show_email/it/

Copilot

Pull Request Overview

This PR migrates the base_user_show_email module from version 18.0 to 19.0. The module enhances Odoo's user interface by clearly separating the login and email fields, which are tightly coupled in recent Odoo versions.

Key changes:

Updated module version to 19.0.1.0.0 in the manifest
Migrated view definitions (tree view and login layout)
Included translation files and documentation

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
base_user_show_email/manifest.py	Updated version to 19.0.1.0.0 and defined module metadata
base_user_show_email/init.py	Empty init file for module structure
base_user_show_email/views/res_users_view.xml	Extends res.users tree view to display email field next to login
base_user_show_email/views/login_layout.xml	Customizes login template to display "Login" label instead of "Email"
base_user_show_email/readme/DESCRIPTION.md	Source file for module description (contains grammar error and mentions missing form view)
base_user_show_email/readme/CONTRIBUTORS.md	Lists module contributors
base_user_show_email/README.rst	Auto-generated documentation (has outdated 18.0 version references)
base_user_show_email/static/description/index.html	Auto-generated HTML documentation (has outdated 18.0 version references)
base_user_show_email/static/description/icon.png	Module icon (binary file)
base_user_show_email/i18n/base_user_show_email.pot	Translation template (has outdated 18.0 version and references missing form view)
base_user_show_email/i18n/it.po	Italian translation (has outdated 16.0 version and references missing form view)
base_user_show_email/pyproject.toml	Build system configuration using whool

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-20T19:02:41Z

base_user_show_email/README.rst

+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/18.0/base_user_show_email>`_ project on GitHub.


The version references in this file still point to 18.0 but should be updated to 19.0 for this migration. The following lines need updating:

Line 20: tree/18.0/base_user_show_email → tree/19.0/base_user_show_email

Line 23: server-auth-18-0 → server-auth-19-0 (twice)

Line 26: target_branch=18.0 → target_branch=19.0

Line 59: version:%2018.0 → version:%2019.0

Line 89: tree/18.0/base_user_show_email → tree/19.0/base_user_show_email

Suggested change

This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/18.0/base_user_show_email>`_ project on GitHub.

This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/19.0/base_user_show_email>`_ project on GitHub.

Copilot · 2025-11-20T19:02:42Z

base_user_show_email/static/description/index.html

+<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-auth/tree/18.0/base_user_show_email">OCA/server-auth</a> project on GitHub.</p>


The version references in this file still point to 18.0 but should be updated to 19.0 for this migration. The following need updating:

Line 372: tree/18.0/base_user_show_email → tree/19.0/base_user_show_email, server-auth-18-0 → server-auth-19-0 (twice), target_branch=18.0 → target_branch=19.0

Line 410: version:%2018.0 → version:%2019.0

Line 436: tree/18.0/base_user_show_email → tree/19.0/base_user_show_email

Suggested change

<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-auth/tree/18.0/base_user_show_email">OCA/server-auth</a> project on GitHub.</p>

<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-auth/tree/19.0/base_user_show_email">OCA/server-auth</a> project on GitHub.</p>

Copilot · 2025-11-20T19:02:42Z

base_user_show_email/i18n/it.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 16.0\n"


The Project-Id-Version references Odoo Server 16.0, but this is a migration to 19.0. While translation files may be carried over from previous versions, for consistency and clarity, this should be updated to "Odoo Server 19.0".

Suggested change

"Project-Id-Version: Odoo Server 16.0\n"

"Project-Id-Version: Odoo Server 19.0\n"

Copilot · 2025-11-20T19:02:42Z

base_user_show_email/readme/DESCRIPTION.md

+- In the res.users form view:  
+  - Display a "Login" label instead of "Email" on the login field
+  - Show the currently invisible email field and its label
+


The DESCRIPTION.md mentions changes to "the res.users form view" (lines 11-13), but the README.rst (which is generated from the description) omits this section and only mentions the tree view (line 41) and login layout (line 45). Additionally, the translation files reference base_user_show_email.user_email_form view, but no form view is included in the views directory. Either:

A form view file is missing from this migration, or

The DESCRIPTION.md is outdated and should be updated to remove the form view references

This inconsistency should be resolved to ensure the module description matches the actual implementation.

Suggested change

- In the res.users form view:

- Display a "Login" label instead of "Email" on the login field

- Show the currently invisible email field and its label

Copilot · 2025-11-20T19:02:43Z

base_user_show_email/readme/DESCRIPTION.md

+field (the field is displayed with an "Email" label, and it will
+populate the email of the user if it contains an "@" character).
+
+Yet for the users who uses a distinct login and email, this is


Grammar error: "for the users who uses" should be "for the users who use" (plural subject requires plural verb form).

Suggested change

Yet for the users who uses a distinct login and email, this is

Yet for the users who use a distinct login and email, this is

Copilot · 2025-11-20T19:02:43Z

base_user_show_email/i18n/base_user_show_email.pot

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 18.0\n"


The Project-Id-Version references "Odoo Server 18.0", but this is a migration to 19.0. This should be updated to "Odoo Server 19.0" for consistency.

Suggested change

"Project-Id-Version: Odoo Server 18.0\n"

"Project-Id-Version: Odoo Server 19.0\n"

Copilot · 2025-11-20T19:02:43Z

base_user_show_email/i18n/base_user_show_email.pot

+#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form
+msgid "Email Address"
+msgstr ""
+
+#. module: base_user_show_email
+#: model_terms:ir.ui.view,arch_db:base_user_show_email.login
+#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form


The translation files reference a view base_user_show_email.user_email_form (lines 17, 23), but this view does not exist in the module's XML files. The module's DESCRIPTION.md mentions form view modifications, but only tree view (res_users_view.xml) and login layout (login_layout.xml) files are included. Either:

The form view file is missing from this migration and needs to be added, or

These translation entries are outdated and should be removed

This should be investigated and resolved to ensure the module works correctly.

Suggested change

#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form

msgid "Email Address"

msgstr ""

#. module: base_user_show_email

#: model_terms:ir.ui.view,arch_db:base_user_show_email.login

#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form

#: model_terms:ir.ui.view,arch_db:base_user_show_email.login

Copilot · 2025-11-20T19:02:44Z

base_user_show_email/i18n/it.po

+#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form
+msgid "Email Address"
+msgstr "Indirizzo e-mail"
+
+#. module: base_user_show_email
+#: model_terms:ir.ui.view,arch_db:base_user_show_email.login
+#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form


The translation file references a view base_user_show_email.user_email_form (lines 20, 23, 26, 27), but this view does not exist in the module's XML files. Either this form view is missing from the migration, or these translation entries are outdated and should be removed. This should be synchronized with the actual module implementation.

Suggested change

#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form

msgid "Email Address"

msgstr "Indirizzo e-mail"

#. module: base_user_show_email

#: model_terms:ir.ui.view,arch_db:base_user_show_email.login

#: model_terms:ir.ui.view,arch_db:base_user_show_email.user_email_form

#. module: base_user_show_email

#: model_terms:ir.ui.view,arch_db:base_user_show_email.login

Patrick Tombez and others added 20 commits November 17, 2025 19:25

[12.0][ADD] base_user_show_email

7f5c671

[UPD] README.rst

b31ce30

[IMP] base_user_show_email: black, isort, prettier

f0be1a9

[MIG] base_user_show_email: Migration to 13.0

96b8113

[UPD] Update base_user_show_email.pot

a00d905

[UPD] README.rst

d6fd238

[MIG] base_user_show_email: Migration to 16.0

c09c1cc

[UPD] Update base_user_show_email.pot

8d397a8

[UPD] README.rst

12008ea

[UPD] README.rst

329d57a

Added translation using Weblate (Italian)

8314564

Translated using Weblate (Italian)

2fcf1bb

Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-16.0/server-auth-16.0-base_user_show_email Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-base_user_show_email/it/

[IMP] base_user_show_email: pre-commit execution

b6c31cb

[17.0][MIG] base_user_show_email: Migration to 17.0

18bfd5b

[IMP] base_user_show_email: pre-commit execution

c39f871

[MIG] base_user_show_email: Migration to 18.0

5000aca

[UPD] Update base_user_show_email.pot

e521cce

[BOT] post-merge updates

d758a63

[IMP] base_user_show_email: pre-commit execution

91686b0

[MIG] base_user_show_email: Migration to 19.0

6a4e654

augusto-weiss marked this pull request as ready for review November 20, 2025 18:58

Copilot AI review requested due to automatic review settings November 20, 2025 18:58

Copilot started reviewing on behalf of augusto-weiss November 20, 2025 18:58 View session

augusto-weiss mentioned this pull request Nov 20, 2025

Migration to version 19.0 #842

Open

19 tasks

Copilot finished reviewing on behalf of augusto-weiss November 20, 2025 19:01

Copilot AI reviewed Nov 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[MIG] base_user_show_email: Migration to 19.0 #867

[MIG] base_user_show_email: Migration to 19.0 #867

Uh oh!

augusto-weiss commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/18.0/base_user_show_email>`_ project on GitHub.
	This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/19.0/base_user_show_email>`_ project on GitHub.

	<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-auth/tree/18.0/base_user_show_email">OCA/server-auth</a> project on GitHub.</p>
	<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-auth/tree/19.0/base_user_show_email">OCA/server-auth</a> project on GitHub.</p>

	"Project-Id-Version: Odoo Server 16.0\n"
	"Project-Id-Version: Odoo Server 19.0\n"

	- In the res.users form view:
	- Display a "Login" label instead of "Email" on the login field
	- Show the currently invisible email field and its label

	Yet for the users who uses a distinct login and email, this is
	Yet for the users who use a distinct login and email, this is

	"Project-Id-Version: Odoo Server 18.0\n"
	"Project-Id-Version: Odoo Server 19.0\n"

Uh oh!

[MIG] base_user_show_email: Migration to 19.0 #867

Are you sure you want to change the base?

[MIG] base_user_show_email: Migration to 19.0 #867

Uh oh!

Conversation

augusto-weiss commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants