[14.0][FIX] l10n_br_product_contract: is_contract #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @rvalyi |
|
Hi @marcelsavegnago, @mileo, |
kaynnan
force-pushed
the
14.0-fix-l10n_br_product_contract
branch
from
2c00ad6 to
7d78b20
Compare
antoniospneto
approved these changes
Jul 12, 2023
rvalyi
approved these changes
Jul 12, 2023
|
faço o merge rápido para destravar geral já que é um fix bem simples e sem risco. /ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
renatonlima
approved these changes
Jul 12, 2023
|
Congratulations, your PR was merged at 6a77c5b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcelsavegnago
Adicionado o field is_contract para o demo referente ao sale.order.line e com esse ajuste o erro relatado nos tests pela PR #2545, fez com que o teste seja executado corretamente.
Seguindo a lógica pelo IMP realizado no product_contract, notei que o product_id.is_contract foi alterado por is_contract, em base disso fiz essa adição do campo ao demo do sale.order.line