Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] hr_employee_birthay_mail: res_users configurable #1267

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[14.0][FIX] hr_employee_birthay_mail: res_users configurable #1267

merged 1 commit into from
Dec 10, 2024

Conversation

JoanSForgeFlow
Copy link

This PR allows each user to grant permission for anniversary notifications from "My profile", otherwise only HR administrators can edit it.

The group "hr.group_hr_user" is also added. Without this group, the open attendances at that time fail and do not allow the attendance session to be closed.

@ForgeFlow

@JoanSForgeFlow JoanSForgeFlow force-pushed the 14.0-fix-hr_employee_birthay_mail-res_users branch from 3fdddda to e69160f Compare July 10, 2023 08:48
JordiMForgeFlow
JordiMForgeFlow approved these changes Jul 10, 2023
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@JoanSForgeFlow JoanSForgeFlow changed the title [FIX] hr_employee_birthay_mail: res_users configurable [14.0][FIX] hr_employee_birthay_mail: res_users configurable Jul 10, 2023
mariadforgeflow
mariadforgeflow approved these changes Jul 10, 2023
View reviewed changes
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Nov 2, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 2, 2023
@OCA-git-bot
Merge PR #1267 into 14.0
6ecad71 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@JoanSForgeFlow JoanSForgeFlow force-pushed the 14.0-fix-hr_employee_birthay_mail-res_users branch 2 times, most recently from 882bf87 to b227b16 Compare February 20, 2024 09:10
@JoanSForgeFlow JoanSForgeFlow mentioned this pull request Feb 23, 2024
Merged
@JoanSForgeFlow JoanSForgeFlow mentioned this pull request Jun 4, 2024
Merged
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 23, 2024
@github-actions github-actions bot closed this Jul 28, 2024
@JoanSForgeFlow
Copy link
Author

@dreispt Is it possible to reopoen and merge? I think it is a needed fix for the module.

Thank you

@dreispt dreispt reopened this Jul 30, 2024
@dreispt
Copy link
Member

dreispt commented Jul 30, 2024

Sure, can you rebase please?

@JoanSForgeFlow JoanSForgeFlow force-pushed the 14.0-fix-hr_employee_birthay_mail-res_users branch from b227b16 to c6a8be9 Compare July 30, 2024 11:33
@JoanSForgeFlow
Copy link
Author

@dreispt Yes, of course. Done!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 8, 2024
@dreispt
Copy link
Member

dreispt commented Dec 10, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 10, 2024
@OCA-git-bot
Merge PR #1267 into 14.0
775c2b9 
Signed-off-by dreispt
@dreispt
Copy link
Member

dreispt commented Dec 10, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aa7a026. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 01099ce into OCA:14.0 Dec 10, 2024
6 of 7 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the 14.0-fix-hr_employee_birthay_mail-res_users branch December 10, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariadforgeflow mariadforgeflow mariadforgeflow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JoanSForgeFlow @OCA-git-bot @dreispt @MiquelRForgeFlow @JordiMForgeFlow @mariadforgeflow