Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FWP][FIX] hr_employee_birthay_mail: res_users configurable #1358

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[16.0][FWP][FIX] hr_employee_birthay_mail: res_users configurable #1358

merged 1 commit into from
Dec 10, 2024

Conversation

JoanSForgeFlow
Copy link

FWP of this FIX: #1267

LoisRForgeFlow
LoisRForgeFlow approved these changes Jun 4, 2024
View reviewed changes
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JoanSForgeFlow
Copy link
Author

JoanSForgeFlow commented Jul 25, 2024 •
edited
Loading

Hi,

Is it possible to merge this PR ?

Thank you

@JoanSForgeFlow
Copy link
Author

@dreispt And also I think we can merge this.

Thank you

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
@dreispt
Copy link
Member

dreispt commented Dec 10, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1358-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 10, 2024
@OCA-git-bot
Merge PR #1358 into 16.0
7e35b34 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1358-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 10, 2024
@OCA-git-bot
Merge PR #1358 into 16.0
9f1b763 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1358-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf85879 into OCA:16.0 Dec 10, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 00f9332. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-fwp-fix-hr_employee_birthday_mail branch December 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoanSForgeFlow @OCA-git-bot @dreispt @LoisRForgeFlow @JordiMForgeFlow