Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] account_statement_import_base: Migration to 18.0 #735

Merged
merged 26 commits into from
Dec 17, 2024
Merged

[18.0][MIG] account_statement_import_base: Migration to 18.0 #735

merged 26 commits into from
Dec 17, 2024

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy commented Nov 7, 2024 •
edited
Loading

No description provided.

alexis-via and others added 25 commits November 5, 2024 11:01
@alexis-via @xaviedoanhduy
Add module account_statement_import_base
038de8d 
The 2 modules account_statement_import_online and
account_statement_import depend on account_statement_import_base (and
not on each other) and share common code, in particular a hook to update
the statement line. So we can now have reconciliation modules that use
this hook and therefore work both on file import and online import. More
details on OCA#481.

Improve bank statement line form view and journal form view.
@alexis-via @xaviedoanhduy
[ADD] module account_statement_import_file_reconciliation_widget
801bbb5 
account_statement_import_file_reconciliation_widget is a glue
auto-install module between account_statement_import (will be renamed
account_statement_import_file in v16) and account_reconciliation_widget.
@OCA-git-bot @xaviedoanhduy
[ADD] icon.png
40b96bd
@alexis-via @xaviedoanhduy
[MIG] account_statement_import_base v14 -> v16
e85d33c
@badbole @xaviedoanhduy
Added translation using Weblate (Croatian)
5ab5d93
@Gelo-fl @xaviedoanhduy
Added translation using Weblate (Spanish)
44077b9
@badbole @xaviedoanhduy
Translated using Weblate (Croatian)
08ad038 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/hr/
@Gelo-fl @xaviedoanhduy
Translated using Weblate (Spanish)
6fdc224 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/es/
@xaviedoanhduy
Added translation using Weblate (French)
239cadd
@xaviedoanhduy
Translated using Weblate (French)
5de6505 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/fr/
@adrianojprado @xaviedoanhduy
Added translation using Weblate (Portuguese (Brazil))
36e3031
@adrianojprado @xaviedoanhduy
Translated using Weblate (Portuguese (Brazil))
a62a7dc 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/pt_BR/
@weblate @xaviedoanhduy
Update translation files
1a7b2e2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/
@pere-aquarian @xaviedoanhduy
Added translation using Weblate (Catalan)
7751eb2
@pere-aquarian @xaviedoanhduy
Translated using Weblate (Catalan)
5d6d692 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/ca/
@rov-adhoc @xaviedoanhduy
[IMP] account_statement_import_base: pre-commit execution
224362c
@rov-adhoc @xaviedoanhduy
[MIG] account_statement_import_base: Migration to 17.0
44deded
@OCA-git-bot @xaviedoanhduy
[BOT] post-merge updates
18656d1
@mymage @xaviedoanhduy
Added translation using Weblate (Italian)
1a13d4b
@mymage @xaviedoanhduy
Translated using Weblate (Italian)
1e9904a 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_base/it/
@mymage @xaviedoanhduy
Translated using Weblate (Italian)
d99bcec 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_base/it/
@xtanuiha @xaviedoanhduy
Added translation using Weblate (Chinese (Simplified) (zh_CN))
9721a4c
@xtanuiha @xaviedoanhduy
Translated using Weblate (Chinese (Simplified) (zh_CN))
ebb7c15 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_base/zh_CN/
@xaviedoanhduy
[IMP] account_statement_import_base: pre-commit auto fixes
971ba1a
@xaviedoanhduy
[MIG] account_statement_import_base: Migration to 18.0
763f0df
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_base branch from d4e683d to 6e85f41 Compare November 7, 2024 08:43
This was referenced Nov 7, 2024
Merged
Open
Open
Open
@xaviedoanhduy xaviedoanhduy mentioned this pull request Nov 11, 2024
Open
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_base branch from 6e85f41 to 1bd2783 Compare November 14, 2024 05:10
@TDu
Copy link
Member

TDu commented Nov 26, 2024

@xaviedoanhduy the dependency has been merged, could you remove the test-requirements commit, thank you

@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_base branch from 1bd2783 to 6734850 Compare November 26, 2024 11:04
@xaviedoanhduy
Copy link
Author

@xaviedoanhduy the dependency has been merged, could you remove the test-requirements commit, thank you

hi @TDu, done!

@cav-adhoc
Copy link

Hi @xaviedoanhduy @henrybackman! Is there anything left pending in this PR that we can help to merge? We need it for account_statement import_file :)
Thanks in advance!

@rov-adhoc
Copy link

@pedrobaeza Hey! I would like to ask you if its something missing in order to be approve. Thanks in advance!

@pedrobaeza
Copy link
Member

/ocabot migration account_statement_import_base

2 reviews are needed and one from a PSC: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

I also think that meanwhile, some more commits have come to previous branches.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 16, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

grindtildeath
grindtildeath approved these changes Dec 17, 2024
View reviewed changes
Copy link

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question ❓

account_statement_import_base/models/account_bank_statement_line.py
Comment on lines +13 to +14
unique_import_id = fields.Char(string="Import ID", copy=False)
raw_data = fields.Text(copy=False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to move readonly from here to the view?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there is a quote in the document, see in: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so avoid it as possible and define the readonly attribute on the views instead.

@grindtildeath
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-735-by-grindtildeath-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a2f51c8 into OCA:18.0 Dec 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e58cf52. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rov-adhoc rov-adhoc rov-adhoc approved these changes

@henrybackman henrybackman henrybackman approved these changes

@grindtildeath grindtildeath grindtildeath approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.