[18.0][MIG] account_statement_import_file: Migration to 18.0 #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
mmequignon
reviewed
Nov 7, 2024
Comment on lines
39
to
41
| f_path = file_path( | ||
| "account_statement_import_file/test_files/test_statement_import.txt" | ||
| ) |
There was a problem hiding this comment.
Why ? This file is only used in unittests no? Why extracting this in another folder?
There was a problem hiding this comment.
hi @mmequignon,
you're right, it should be in the /tests/samples folder because there is a convention for that type of file in
so on this occasion, i have moved it to the
/tests/samples folder
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_file
branch
from
3fe6add to
32cd6ec
Compare
This was referenced Nov 8, 2024
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_file
branch
from
32cd6ec to
27ef63d
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_file
branch
from
27ef63d to
51ded18
Compare
henrybackman
approved these changes
Dec 6, 2024
grindtildeath
approved these changes
Dec 17, 2024
The module was renamed from account_statement_import to account_statement_import_file. The migration has been done from v14 to v16, to take into account the big changes that took place in v14 with the introduction of the module account_statement_import_base. The changes from v15 have been forward-ported to v16.
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/hr/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/fr/
Currently translated at 58.3% (21 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
…ue to file_import_oca
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/ca/
Currently translated at 72.2% (26 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/it/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/it/
…eld attachment_ids
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_file/sv/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_file/zh_CN/
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_file
branch
from
51ded18 to
a13a4af
Compare
rov-adhoc
approved these changes
Dec 17, 2024
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 704b568. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
change in v18
menu_finance_entries_actions(Accounting/Actions) was removed in commit: odoo/odoo@70a2618