Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #133

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update README.md #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ Herein outlines the components of the project and their purposes.

This contract provides the store for arbitrary DA blobs. In practice, these "blobs" are sequencing data from rollups, but they can be any data.

NEAR blockchain state storage is pretty cheap. At the time of writing, 100KiB is a flat fee of 1NEAR.
To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
NEAR blockchain state storage is pretty cheap. To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

LGTM! Consider a minor enhancement for clarity.

The removal of specific state costs and focus on the cost-reduction strategy improves maintainability and prevents confusion. However, consider adding a link to NEAR's official documentation about storage costs for users who want current pricing information.

-NEAR blockchain state storage is pretty cheap. To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
+NEAR blockchain state storage is pretty cheap (see [official pricing](https://docs.near.org/concepts/storage/storage-staking)). To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
NEAR blockchain state storage is pretty cheap. To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
NEAR blockchain state storage is pretty cheap (see [official pricing](https://docs.near.org/concepts/storage/storage-staking)). To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.


It works by taking advantage of NEAR consensus around receipts.
When a chunk producer processes a receipt, there is consensus around the receipt.
Expand Down