-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #133
Update README.md #133
Conversation
Seems like people confuse the costs when we put the state costs instead of receipt costs, so I'm removing it.
WalkthroughThe changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant README
User->>README: Request for information on NEAR blockchain state storage
README-->>User: Provides clear and concise explanation
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range comments (1)
README.md (1)
Line range hint
82-82
: Consider tracking the TODO item in GitHub Issues.The TODO comment about writing and drawing up extensions to the light client and architecture diagram should be tracked in a GitHub issue for better visibility and follow-up.
Would you like me to create a GitHub issue to track this task?
@@ -13,8 +13,7 @@ Herein outlines the components of the project and their purposes. | |||
|
|||
This contract provides the store for arbitrary DA blobs. In practice, these "blobs" are sequencing data from rollups, but they can be any data. | |||
|
|||
NEAR blockchain state storage is pretty cheap. At the time of writing, 100KiB is a flat fee of 1NEAR. | |||
To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state. | |||
NEAR blockchain state storage is pretty cheap. To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
LGTM! Consider a minor enhancement for clarity.
The removal of specific state costs and focus on the cost-reduction strategy improves maintainability and prevents confusion. However, consider adding a link to NEAR's official documentation about storage costs for users who want current pricing information.
-NEAR blockchain state storage is pretty cheap. To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
+NEAR blockchain state storage is pretty cheap (see [official pricing](https://docs.near.org/concepts/storage/storage-staking)). To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
NEAR blockchain state storage is pretty cheap. To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state. | |
NEAR blockchain state storage is pretty cheap (see [official pricing](https://docs.near.org/concepts/storage/storage-staking)). To limit the costs of NEAR storage even more, we don't store the blob data in the blockchain state. |
How much more the costs of NEAR storage are lowered by this approach? |
Seems like people confuse the costs when we put the state costs instead of receipt costs, so I'm removing it.
This change is
Summary by CodeRabbit
README.md
file.