Fix comment. #12
Open
Fix comment. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasan6979
reviewed
Dec 17, 2024
kevincox
force-pushed
the
saturating-comment
branch
from
6d6e95e to
5111975
Compare
Hasan6979
reviewed
Dec 18, 2024
neptun/src/sleepyinstant/mod.rs
Outdated
| /// # Panics | ||
| /// | ||
| /// panics when `earlier` was later than `self`. | ||
| /// Returns `Duration::ZERO` when `earlier` was later than `self`. |
There was a problem hiding this comment.
This seems redundant now looking at line 51. 😅
There was a problem hiding this comment.
Yeah, I really should have taken a holistic look at this comment rather than just deleting the bad bit. I think we can drop everything after the last line.
The underlying method saturates. This comment was likely written with an old underlying implementation. Signed-off-by: Kevin Cox <[email protected]>
kevincox
force-pushed
the
saturating-comment
branch
from
5111975 to
a374b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying method saturates. This comment was likely written with an old underlying implementation.
I was reading over the code to check for possible panics in Duration arithmetic and noticed this inconsistency in the comment. I may have misunderstood something but it seems that this just calls a method which saturates.
NepTUN/neptun/src/sleepyinstant/unix.rs
Line 44 in 6d6e95e