buck2: 2024-10-15 -> 2025-01-02

[thoughtpolice]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nickgerace]

I am trying to test this PR, but I think I am running into Mic92/nixpkgs-review#447 due to the recent infrastructure changes (#355847). I'll try again when I'm back at my desk.

[lucasew]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370393

---

x86_64-linux

✅ 1 package built:

• buck2

[nickgerace]

The Eval / Tag check appears to be incorrect and may be related to the ongoing infrastructure changes. Everything looks good to me and is accordance to previous PRs for this package. I'm going to attempt to merge.

[nickgerace]

@NixOS/nixpkgs-merge-bot merge

[nixpkgs-merge-bot]

@nickgerace merge not permitted (#305350):
pkgs/development/tools/build-managers/buck2/default.nix is not in pkgs/by-name/
pkgs/development/tools/build-managers/buck2/hashes.json is not in pkgs/by-name/

[nickgerace]

@thoughtpolice hmmm I'm wondering if the repository structure changed post 24.11?
#370393 (comment)

[nickgerace]

Ah it seems like that's the case.

• Here's the RFC: RFC 140 migration plan #258650
• Here's the bu directory: https://github.com/NixOS/nixpkgs/tree/8d75e9b97841ab08a6efa20ff91d927a52e8e667/pkgs/by-name/bu
• A contributor experiencing a similar issue: Implement automated migrations nixpkgs-vet#56 (comment)

I think once we adhere to new paradigm, we should be good to go.