Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: buck2 2024-10-15 → 2025-01-02 #370366

Closed
1 task done
nickgerace opened this issue Jan 2, 2025 · 6 comments
Closed
1 task done

Update request: buck2 2024-10-15 → 2025-01-02 #370366

nickgerace opened this issue Jan 2, 2025 · 6 comments
Labels
9.needs: package (update) This needs a package to be updated

Comments

@nickgerace
Copy link
Contributor

nickgerace commented Jan 2, 2025

Package Information

  • Package name: buck2
  • Latest released version: 2025-01-02
  • Current version on the unstable channel: 2024-10-15
  • Current version on the stable/release channel: 2024-10-15 (checked 24.11)

Checklist

Notify maintainers

@thoughtpolice

Extra notes

Hi @thoughtpolice! Thought filing this issue would be the best way to talk about this in accordance with the repository guidelines and issue templates.

I'm curious, do you think it is possible for r-ryantm / nixpkgs-update to pick up buck2 updates in the future? I see that the custom update script also updates the prelude, which is awesome.

For context: maintain the reindeer package, which uses the generic update script, but it is much less involved than the buck2 updates.

cc @fnichol @sprutton1 since you'd be interested

@nickgerace nickgerace added the 9.needs: package (update) This needs a package to be updated label Jan 2, 2025
@thoughtpolice
Copy link
Member

thoughtpolice commented Jan 2, 2025

#370393

This was generated automatically using the command nix-shell maintainers/scripts/update.nix --argstr package buck2 run from the root of the nixpkgs repository; it was my understanding that this is all that was needed for nixpkgs-update/r-ryantm to kick in, so I'm afraid I don't know why this package has been left behind.

@thoughtpolice
Copy link
Member

#370397 for a reindeer update as well, because why not?

@nickgerace
Copy link
Contributor Author

@thoughtpolice thanks for the reindeer PR! I actually merged the original just now, so we're good there :)

Thank you for the buck2 PR too! Hm... I don't know why the bot isn't picking it up. I think you are right since all it should need is the passthru script, but maybe we are missing something in the FAQ?

@nickgerace
Copy link
Contributor Author

nickgerace commented Jan 2, 2025

Ah I think your link goes back to this issue. Looks like this is the PR link: #370393

@thoughtpolice
Copy link
Member

thoughtpolice commented Jan 3, 2025

Fixed by #370393

@nickgerace
Copy link
Contributor Author

Thank you @thoughtpolice 😄 I'll look into the auto updates too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

No branches or pull requests

2 participants