Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-aoc: init at 0.3.8 #362859

Merged
merged 1 commit into from
Dec 9, 2024
Merged

cargo-aoc: init at 0.3.8 #362859

merged 1 commit into from
Dec 9, 2024

Conversation

Defelo
Copy link
Member

@Defelo Defelo commented Dec 7, 2024

cargo-aoc is a simple CLI tool that aims to be a helper for Advent of Code.

https://github.com/gobanos/cargo-aoc

Closes #362526

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pyrox0
Copy link
Member

pyrox0 commented Dec 7, 2024

Result of nixpkgs-review pr 362859 run on x86_64-linux 1

1 package built:
  • cargo-aoc

(I don't have a darwin machine to try this on, but I don't see any issues that would come up)

pkgs/by-name/ca/cargo-aoc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ca/cargo-aoc/package.nix Show resolved Hide resolved
pkgs/by-name/ca/cargo-aoc/package.nix Show resolved Hide resolved
pkgs/by-name/ca/cargo-aoc/package.nix Outdated Show resolved Hide resolved
@Defelo Defelo changed the title cargo-aoc: init at 0.3.7 cargo-aoc: init at 0.3.8 Dec 8, 2024
@Defelo
Copy link
Member Author

Defelo commented Dec 8, 2024

@getchoo Thanks for your review! While applying your suggestion to add the version test (which didn't work at first, because 0.3.7 contained a bug which caused --version to report a wrong version) I noticed that a newer version 0.3.8 has been released on crates.io (but not on GitHub). Since their README.md recommends installing the package using cargo install anyway, I now also fetch the source from crates.io

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 8, 2024
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OfBorg is happy, and everything here LGTM. Feel free to ping me in a couple days if no one else comes to merge :)

@Defelo Defelo added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 9, 2024
@SuperSandro2000 SuperSandro2000 merged commit 588b138 into NixOS:master Dec 9, 2024
47 of 48 checks passed
@Defelo Defelo deleted the cargo-aoc branch December 9, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: cargo-aoc
4 participants