Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: cargo-aoc #362526

Closed
Tygo-van-den-Hurk opened this issue Dec 6, 2024 · 5 comments · Fixed by #362859
Closed

Package request: cargo-aoc #362526

Tygo-van-den-Hurk opened this issue Dec 6, 2024 · 5 comments · Fixed by #362859
Labels
0.kind: packaging request Request for a new package to be added

Comments

@Tygo-van-den-Hurk
Copy link

Project description

"cargo-aoc is a simple CLI tool that aims to be a helper for the Advent of Code. Implement your solution. Let us handle the rest."

  • from their cargo page

Features

  • Input downloading
  • Running your solution
  • Automatic benchmarking of your solution using Criterion

Metadata


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@Tygo-van-den-Hurk Tygo-van-den-Hurk added the 0.kind: packaging request Request for a new package to be added label Dec 6, 2024
@Defelo Defelo mentioned this issue Dec 7, 2024
13 tasks
@Defelo
Copy link
Member

Defelo commented Dec 7, 2024

@Tygo-van-den-Hurk I created a pull request at #362859, maybe you could have a look at it?

@Tygo-van-den-Hurk
Copy link
Author

Tygo-van-den-Hurk commented Dec 7, 2024

First of all, thank you for making this!

I wouldn't mind, however I'm not intimately familiar with packaging. I'd like to get better at this so if you could give me some pointers of what you usually look at to check that'd be nice and then I'll take another look. Without some hand holding I won't be of much use I'm afraid.

@Defelo
Copy link
Member

Defelo commented Dec 7, 2024

No problem! For starters you could verify that the package name, version, source (github repo crates.io package), and metadata (description, homepage, license, ...) all match what you would expect. Then you could check that the package actually builds and works as intended, e.g. using nix shell github:nixos/nixpkgs/pull/362859/merge#cargo-aoc and then cargo aoc ...

@Tygo-van-den-Hurk
Copy link
Author

Tygo-van-den-Hurk commented Dec 8, 2024

Ah okay, got it!

  • All the metadata checks out, though I am personally confused with the license not being on the GH page.
  • Checked if it builds and it does, also appears to function as normal!

PS. Thank you for teaching me how to test packages I had no idea what to do otherwise :)

@Defelo
Copy link
Member

Defelo commented Dec 8, 2024

Great! About the license, for some reason they have put it into the cargo-aoc directory instead of the project root, so GitHub doesn't detect it automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants