Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfdyndns: 0.2.0 -> 0.2.1 #323632

Closed
wants to merge 1 commit into from
Closed

cfdyndns: 0.2.0 -> 0.2.1 #323632

wants to merge 1 commit into from

Conversation

mcwitt
Copy link
Contributor

@mcwitt mcwitt commented Jun 30, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from colemickens June 30, 2024 18:56
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 30, 2024
@getchoo
Copy link
Member

getchoo commented Jul 3, 2024

Result of nixpkgs-review pr 323632 run on aarch64-linux 1

1 package built:
  • cfdyndns

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 3, 2024
@Aleksanaa
Copy link
Member

The update has already been performed in #323855.

@Aleksanaa
Copy link
Member

Just leave it as is. I seem to find some bugs in the merge conflict detection.

@Aleksanaa Aleksanaa marked this pull request as draft July 3, 2024 04:42
@Aleksanaa Aleksanaa marked this pull request as ready for review July 3, 2024 04:42
@Aleksanaa Aleksanaa closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants