dayon: init at 11.0.7 #226155
Merged
dayon: init at 11.0.7 #226155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidak
reviewed
Apr 18, 2023
| postPatch = '' | ||
| substituteInPlace resources/deb/dayon_assisted.desktop resources/deb/dayon_assistant.desktop \ | ||
| --replace "Exec=/usr/bin" "Exec=$out/bin" \ | ||
| --replace "Icon=/usr/bin/dayon/dayon.png" "Icon=dayon.png" |
There was a problem hiding this comment.
You could propose a patch to upstream to make it more portable for everyone.
There was a problem hiding this comment.
You mean using basenames for both Icon and Exec?
There was a problem hiding this comment.
Whatever helps it to work not only in /usr/bin. I don't know the solution.
There was a problem hiding this comment.
I proposed a patch upstream RetGal/Dayon#66
davidak
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
An easy to use, cross-platform remote desktop assistance solution
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)