Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rustdesk with Flutter GUI #211751

Closed
davidak opened this issue Jan 20, 2023 · 8 comments
Closed

Build rustdesk with Flutter GUI #211751

davidak opened this issue Jan 20, 2023 · 8 comments

Comments

@davidak
Copy link
Member

davidak commented Jan 20, 2023

Describe the bug

I can't use rustdesk, because it uses unfree libraries, which are forbidden on my system.

It seem now possible to build it with Flutter.

Upstream issue: rustdesk/rustdesk#900

Steps To Reproduce

Steps to reproduce the behavior:

[davidak@gaming:~]$ nix run nixpkgs#rustdesk
error: Package ‘libsciter-4.4.8.23-bis’ in /nix/store/ld350gbq2w5654yw4q95kxhxp4569zi6-source/pkgs/development/libraries/libsciter/default.nix:40 has an unfree license (‘unfree’), refusing to evaluate.

       a) To temporarily allow unfree packages, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_UNFREE=1

        Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+
        (Flake) command, `--impure` must be passed in order to read this
        environment variable.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowUnfree = true; }
       in configuration.nix to override this.

       Alternatively you can configure a predicate to allow specific packages:
         { nixpkgs.config.allowUnfreePredicate = pkg: builtins.elem (lib.getName pkg) [
             "libsciter"
           ];
         }

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnfree = true; }
       to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)

Expected behavior

the open source TeamViewer alternative

Additional context

rustdesk/rustdesk@f830b39
rustdesk/rustdesk#103

I think we have to wait for a new release if the change is already committed to master.

Notify maintainers

@Leixb

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.1.3, NixOS, 22.11 (Raccoon), 22.11.1629.2f9fd351ec3
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.11.1
  • channels(root): "home-manager-22.11.tar.gz, nixos-22.11, nixos-hardware, nixos-unstable"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos
@fgaz
Copy link
Member

fgaz commented Apr 14, 2023

@davidak meanwhile you might be interested in a similar program I just packaged: #226155

@Leixb Leixb mentioned this issue Jul 9, 2023
12 tasks
@dr460nf1r3
Copy link
Member

Rustdesk is now built with flutter in nixos-unstable.

@Leixb
Copy link
Member

Leixb commented Sep 23, 2023

@dr460nf1r3 Unfortunately, it's not built with flutter.

I could not get flutter.buildFlutterApplication to work (as explained in the PR). I opted to update the sciter and leave the flutter build for when I have more time. If anyone wants to pick this up, feel free to do so, I probably won't have time to look at it until late November.

@dr460nf1r3
Copy link
Member

Now that is embarrassing. My apologies!

@fgaz fgaz reopened this Sep 24, 2023
@sjau
Copy link

sjau commented Nov 8, 2023

Rustdesk is now built with flutter in nixos-unstable.

I can't find any options for Rustdesk server in the nixos options page https://search.nixos.org/options?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=rustdesk

@anoadragon453
Copy link
Member

An additional benefit to being able to mark rustdesk as free is that it can then be built and cached by hydra.nixos.org.

Sent from a very warm laptop that just built rustdesk.

@Leixb
Copy link
Member

Leixb commented Feb 5, 2024

There is now rustdesk-flutter #286129 thanks to the amazing work from @dasJ

@mweinelt mweinelt closed this as completed Feb 5, 2024
@ShalokShalom
Copy link

ShalokShalom commented Feb 8, 2024

I like to mention, that there might be good reasons to not provide Ruskdesk at all.

https://www.reddit.com/r/selfhosted/comments/14kjvkg/community_consensus_on_rustdesk_with_all_the/

https://news.ycombinator.com/item?id=39256493

There are other reports online, who speak of very poor code quality, to the extend that the author uses solutions who are objectively worse alternatives to fundamental Rust techniques. Also general code smell, no/bad commenting and so on.

They are also deleting and banning posts/users on their Subreddit and even Github issues, who raise concerns.

We should look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants