pulseaudio-dlna: unstable-2017-11-01 -> unstable-2021-11-09

[flokli]

This moves pulseaudio-dlna to a more recent fork, which works with
Python 3.

Motivation for this change

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[thiagokokada]

Please fix the commit and PR title:

pulseaudio-dlna: unstable-2017-11-01 -> unstable-2021-11-19

[flokli]

@thiagokokada thanks for spotting 😆 It seems I copied the same line into the commit message ;-)

[thiagokokada]

Got the following error while running:

Traceback (most recent call last):
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 617, in run
    self._connect(signals)
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 55, in _connect
    self.bus = self._get_bus()
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 138, in _get_bus
    modules = self.get_modules()
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 233, in get_modules
    process = subprocess.Popen(
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pactl'

I think you need to add pulseaudio to propagatedBuildInputs 🤔 ?

[flokli]

Got the following error while running:

Traceback (most recent call last):
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 617, in run
    self._connect(signals)
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 55, in _connect
    self.bus = self._get_bus()
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 138, in _get_bus
    modules = self.get_modules()
  File "/nix/store/jwz6d7273pif6v1g7r0dskcls0x6jw56-pulseaudio-dlna-unstable-2021-11-09/lib/python3.9/site-packages/pulseaudio_dlna/pulseaudio.py", line 233, in get_modules
    process = subprocess.Popen(
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/fkzla307l4mlcvfyshsrccwl7szihx2z-python3-3.9.6/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pactl'

I think you need to add pulseaudio to propagatedBuildInputs thinking ?

pulseaudio-dlna picks pactl from $PATH. We could prefix $PATH to add it, but this hasn't changed in this PR - maybe there's valid reasons we don't hardcode this (as people might use different flavours of pulseaudio, and pactl should use the right one).

[thiagokokada]

pulseaudio-dlna picks pactl from $PATH. We could prefix $PATH to add it, but this hasn't changed in this PR - maybe there's valid reasons we don't hardcode this (as people might use different flavours of pulseaudio, and pactl should use the right one).

Yeah, but I think packages should be as hermetic as possible. Specially if this is something that seems to be not optional.

In my case, I am using PipeWare. So while I have full PulseAudio compatibility, I don't have pactl in my PATH (I could include it though).

But anyway, this is just my vision. Some other reviewer may have theirs. I am fine either way.

[flokli]

@thiagokokada I pushed another version, which prefers pactl from $PATH, then falls back the one provided by pulseaudio.

In my case, I am using PipeWare. So while I have full PulseAudio compatibility, I don't have pactl in my PATH (I could include it though).

Note you can't test this with PipeWire, as it's very specific to pulseaudio, and requires more than just a pulseaudio-like interface to play sound to.

[thiagokokada]

Result of nixpkgs-review pr 146915 run on x86_64-linux 1

1 package built:

• pulseaudio-dlna

[thiagokokada]

Since there doesn't seem to be a better solution, I am going to merge.

Just waiting the eval checks.

[github-actions]

Successfully created backport PR #147712 for release-21.11.