Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseaudio-dlna: unstable-2017-11-01 -> unstable-2019-02-09 #119469

Closed
wants to merge 1 commit into from
Closed

pulseaudio-dlna: unstable-2017-11-01 -> unstable-2019-02-09 #119469

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 14, 2021 •
edited
Loading

Motivation for this change

Fixes #108394

Part of #101964

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak marked this pull request as draft April 14, 2021 21:56
@prusnak
Copy link
Member Author

prusnak commented Apr 14, 2021 •
edited
Loading

WIP - the build fails with:

ERROR: Could not find a version that satisfies the requirement dbus-python (from pulseaudio-dlna)
ERROR: No matching distribution found for dbus-python

even when dbus-python is mentioned in propagatedBuildInputs.

@prusnak prusnak mentioned this pull request Apr 14, 2021
Closed
@ofborg ofborg bot requested a review from mogorman April 14, 2021 22:05
SuperSandro2000
SuperSandro2000 reviewed Apr 16, 2021
View reviewed changes
pkgs/applications/audio/pulseaudio-dlna/default.nix
++ [ zeroconf ]
propagatedBuildInputs = [
chardet
dbus-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

ERROR: No matching distribution found for dbus-python>=1.0.0

We have 1.2.X https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/dbus/default.nix#L6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not sure what is going on there. That's the reason why this PR is in the draft state.

@prusnak prusnak changed the title pulseaudio-dlna: unstable-2017-11-01 -> unstable-2021-01-21 pulseaudio-dlna: unstable-2017-11-01 -> unstable-2019-02-09 Sep 2, 2021
@flokli flokli mentioned this pull request Nov 28, 2021
Merged
13 tasks
@flokli
Copy link
Contributor

flokli commented Nov 28, 2021

Let's close this in favor of #146915.

@flokli flokli closed this Nov 28, 2021
@prusnak prusnak deleted the pulseaudio-dlna branch November 28, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@mogorman mogorman Awaiting requested review from mogorman

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulseaudio-dlna: build failure: needs python >=3.6
3 participants
@prusnak @flokli @SuperSandro2000