fix Issue #46 #50
Closed
fix Issue #46 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Nimrodda
reviewed
Dec 4, 2023
| @@ -385,7 +385,7 @@ void call_HandlePTRRecord(const void* p, const void* base, boolean last, STRING_ | |||
| } | |||
|
|
|||
| void call_HandleTXTRecord(const void* p, const void* base, boolean last, STRING_ARG_DECL(key), STRING_ARG_DECL(value)) { | |||
| ((MdnsRequest*)p)->callbackTXT(base, last, STRING_ARG_CALL(key), STRING_ARG_CALL(value)); | |||
| ((MdnsRequest*)p)->callbackTXT(base, last, STRING_ARG_CALL(key), STRING_ARG_CALL(key)); | |||
There was a problem hiding this comment.
why value is changed to key here?
There was a problem hiding this comment.
Huh. I fixed this earlier. Why did this regress?
There was a problem hiding this comment.
I have no idea :D but I guess it should be value, right?
|
Seems like a merge issue on my side? Weird I didn't see that
…On Mon, Dec 4, 2023, 12:55 AM Nimrod Dayan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In windows/flutter_nsd_plugin.cpp
<#50 (comment)>:
> @@ -385,7 +385,7 @@ void call_HandlePTRRecord(const void* p, const void* base, boolean last, STRING_
}
void call_HandleTXTRecord(const void* p, const void* base, boolean last, STRING_ARG_DECL(key), STRING_ARG_DECL(value)) {
- ((MdnsRequest*)p)->callbackTXT(base, last, STRING_ARG_CALL(key), STRING_ARG_CALL(value));
+ ((MdnsRequest*)p)->callbackTXT(base, last, STRING_ARG_CALL(key), STRING_ARG_CALL(key));
why value is changed to key here?
—
Reply to this email directly, view it on GitHub
<#50 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGPGOTCHM2WRELV5LONZHDYHWFWTAVCNFSM6AAAAABAE7U5OSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRRHA3TQMJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
yeah, no worries. whenever you have the time. |
|
I'll close this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment out verbose printf statements which were causing compilation issues on windows