Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 45 #49

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Issue 45 #49

merged 4 commits into from
Dec 4, 2023

Conversation

jnstahl
Copy link
Contributor

@jnstahl jnstahl commented Dec 3, 2023

add missing NEARBY_DEVICES permission to android manifest

@jnstahl
Copy link
Contributor Author

jnstahl commented Dec 3, 2023

windows build failure should be fixed by pull request #50

Copy link
Owner

@Nimrodda Nimrodda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I commented on your other PR though so can't merge.

@jnstahl
Copy link
Contributor Author

jnstahl commented Dec 4, 2023

dont forget to merge this one

@Nimrodda
Copy link
Owner

Nimrodda commented Dec 4, 2023

dont forget to merge this one

I would like to merge it but the windows build is still failing unfortunately...
but it's not related to your PR of course
it would be great if you can have a look 🙏

@Nimrodda Nimrodda merged commit 58d701a into Nimrodda:master Dec 4, 2023
4 of 5 checks passed
@jnstahl
Copy link
Contributor Author

jnstahl commented Dec 4, 2023

the windows build was failing before - it is fixed with the other PR

@Nimrodda
Copy link
Owner

Nimrodda commented Dec 4, 2023

yes, sorry. I forgot that this branch was not rebased with master branch that had the fix. All good. Thanks! :)

@jnstahl jnstahl deleted the issue_45 branch December 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants