Repository navigation
Conversation
The openstudio-cmake-tools images (noble-main amd64/arm64, almalinux9-main) already set LANG, LANGUAGE and LC_ALL in their image config. Closes #5699
Contributor
🧪 Test Results DashboardSummary
✅ All Tests Passed!📊 Test Run Information
|
Collaborator
|
CI Results for ed5befd:
|
This was referenced Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5699.
The
nrel/openstudio-cmake-toolsimages used here already setLANG=en_US.UTF-8,LANGUAGE=en_US:enandLC_ALL=en_US.UTF-8in their image config (checked withcrane configfornoble-mainon linux/amd64 and linux/arm64, and foralmalinux9-main). So-e LANG=en_US.UTF-8does nothing. This removes it fromincremental-build.ymland all threefull-build.ymlLinux matrix entries. No workflow step readsLANGor the locale directly.Testing: Full Build runs on this PR and covers the three
full-build.ymlentries. The incremental build covers the other one once the PR has thePull Request - Ready for CIlabel.Merge note: this touches the same line of
incremental-build.ymlas #5682 (which removes--privileged). Whichever merges second needs a one-line conflict fix; the result should beoptions: -u root # ....🤖 Generated with Claude Code