Repository navigation
Conversation
Both start a measure manager server after checking that a port is free, so when CTest runs them in parallel they can pick the same port and one test talks to the other's server. Closes #5701
anchapin
added
the
Pull Request - Ready for CI
Contributor
🧪 Test Results DashboardSummary
✅ All Tests Passed!📊 Test Run Information
|
Collaborator
|
CI Results for 61824e8:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5701.
OpenStudioCLI.test_measure_managerandOpenStudioCLI.Classic.test_measure_managereach start a measure-manager server.get_open_port_for_serving()checks that a port is free, closes the socket, then launches the server, so when CTest runs both at once they can pick the same port and one test talks to the other's server. That's what failed Ubuntu 24.04 x64 in Full Build run 42922295432 on #5700 (port=8090 is already in use, then the other CLI's responses).This adds a shared
RESOURCE_LOCKso CTest never runs them at the same time, the same waysrc/cli/CMakeLists.txtalready locks thecompact_oswtests. The lock also applies when CTest re-runs failed tests.Testing: checked in a scratch CMake project that
ctest --show-only=json-v1listsRESOURCE_LOCK measure_manager_porton both tests. CI on this PR runs both tests on every platform.🤖 Generated with Claude Code