Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Fix empty softwareProperties field in worker_info.yaml file for profiling tool #623

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[FEA] Fix empty softwareProperties field in worker_info.yaml file for profiling tool #623

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3582fb7
fixed null softwareProperties issue for clusterProperties
cindyyuanjiang Oct 19, 2023
5d60350
refactored code
cindyyuanjiang Oct 19, 2023
57dfc6b
added lod info for empty softwareProperties
cindyyuanjiang Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/AutoTuner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,12 @@ object AutoTuner extends Logging {
representer.getPropertyUtils.setSkipMissingProperties(true)
val constructor = new Constructor(classOf[ClusterProperties], new LoaderOptions())
val yamlObjNested = new Yaml(constructor, representer)
Option(yamlObjNested.load(clusterProps).asInstanceOf[ClusterProperties])
val loadedClusterProps = yamlObjNested.load(clusterProps).asInstanceOf[ClusterProperties]
if (loadedClusterProps != null && loadedClusterProps.softwareProperties == null) {
logInfo("softwareProperties is empty from input worker_info file")
loadedClusterProps.softwareProperties = new util.LinkedHashMap[String, String]()
nartal1 marked this conversation as resolved.
Show resolved Hide resolved
}
Option(loadedClusterProps)
}

def loadClusterProps(filePath: String): Option[ClusterProperties] = {
Expand Down
Loading