Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Fix empty softwareProperties field in worker_info.yaml file for profiling tool #623

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

cindyyuanjiang
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang commented Oct 19, 2023

Fixes #608

Currently, when the worker_info.yaml file has empty softwareProperties field as below, the profiling tool throws a null pointer exception.

system:
  numCores: 32
  memory: 212992MiB
  numWorkers: 5
gpu:
  memory: 15109MiB
  count: 4
  name: T4
softwareProperties:

We work around this by assigning an empty LinkedHashMap (default) to softwareProperties if it is null after loading the worker_info.yaml file into a ClusterProperties instance.

@cindyyuanjiang cindyyuanjiang self-assigned this Oct 19, 2023
@cindyyuanjiang cindyyuanjiang added feature request New feature or request core_tools Scope the core module (scala) labels Oct 19, 2023
Signed-off-by: cindyyuanjiang <[email protected]>
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang.

@cindyyuanjiang cindyyuanjiang merged commit 68be7cb into NVIDIA:dev Oct 23, 2023
8 checks passed
@cindyyuanjiang cindyyuanjiang deleted the fix-null-pointer-ex branch October 23, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Improve profiling tool error message for corrupted work_info file
3 participants