Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document config object in DCGM Exporter values #935

Closed

Conversation

chipzoller
Copy link
Contributor

Signed-off-by: chipzoller [email protected]

This PR documents the existence of the config struct in the ClusterPolicy by adding it, and a description, to the values file. The value has been commented out but can also be uncommented with config.name left as an empty string to be consistent with other areas of the chart.

Signed-off-by: chipzoller <[email protected]>
@chipzoller
Copy link
Contributor Author

Can I get a review here please, @cdesiniotis or @tariq1890?

Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipzoller
Copy link
Contributor Author

Superseded by #949

@chipzoller chipzoller closed this Aug 23, 2024
@chipzoller chipzoller deleted the cz-dcgm-exporter-doc-config branch August 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants