-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support for new customMetrics
value in DCGM Exporter
#934
Comments
Relates to #935 |
@chipzoller thanks for the feature request. Our helm chart offers a similar experience for the k8s-device-plugin and mig-manager configuration files, where the user can provide the ConfigMap data directly via the values.yaml file, as opposed to creating a ConfigMap beforehand. See https://github.com/NVIDIA/gpu-operator/blob/v24.6.1/deployments/gpu-operator/values.yaml#L263-L291 and https://github.com/NVIDIA/gpu-operator/blob/v24.6.1/deployments/gpu-operator/values.yaml#L361-L399. We may want to provide a similar set of fields in the values file for dcgm-exporter. PRs are welcome if you are interested in taking this on. cc @tariq1890 |
Hi @cdesiniotis, yep, totally, but because everything behind the scenes is handled by templating the |
The required changes should be contained to just the helm values and templates. We shouldn't need to extend the CRD at all. See the PR which added this feature to the mig-manager component: #803 |
I see. Looks like it should piggyback off the |
@cdesiniotis, can you help unblock me here? |
Thanks for your help, @cdesiniotis. PR is up at #949. |
NVIDIA/dcgm-exporter#351 adds support for user-definable custom metrics directly in the Helm values file which greatly simplifies the user experience needed when deploying DCGM Exporter with emission of custom metrics. Adding support for this field in the operator's values file would be very useful. Without it, users would have to resort to the (values-file undocumented) field in the ClusterPolicy at
config
, which accepts the name of a ConfigMap, meaning users have to pre-create this prior to deploying the operator (see also template ref here).Please consider adding support for the new
customMetrics
field in the ClusterPolicy CRD and, by extension, in the Helm values of the operator to allow users to deploy the operator and DCGM Exporter with a list of custom metrics upfront.The text was updated successfully, but these errors were encountered: