-
Notifications
You must be signed in to change notification settings - Fork 81
Add docs and example tests to barrier #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and example tests to barrier #449
Conversation
@cwilkinson76 may I get your review on this |
# Test 2: Barrier with forced settings | ||
settings_forced = SolverSettings() | ||
settings_forced.set_parameter(CUOPT_METHOD, SolverMethod.Barrier) | ||
settings_forced.set_parameter(CUOPT_FOLDING, 1) # Force folding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem can't be used to test folding. As it can't be folded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-maes This test is more towards testing whether API workflow works and there are no gaps. but I am happy to make changes to this test to use other bigger problems, can you please suggest a mps file that I can use to test this ?
/ok to test f13d140 |
…t_public into barrier_doc_and_tests
/ok to test 0b97621 |
/ok to test 373a59b |
/ok to test ffca33f |
/ok to test cd979cf |
…t_public into barrier_doc_and_tests
/ok to test 93d013a |
/ok to test 668ded7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ok to test f50b7b1 |
/ok to test 5d56842 |
/ok to test b6a7ad5 |
/merge |
1 similar comment
/merge |
Description
This PR is a follow-up for PR #272 to add documentation and additional tests
Checklist