Skip to content

Conversation

rgsl888prabhu
Copy link
Collaborator

Description

This PR is a follow-up for PR #272 to add documentation and additional tests

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested review from a team as code owners October 6, 2025 16:16
@rgsl888prabhu rgsl888prabhu self-assigned this Oct 6, 2025
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Oct 6, 2025
@rgsl888prabhu
Copy link
Collaborator Author

@cwilkinson76 may I get your review on this

@rgsl888prabhu rgsl888prabhu added this to the 25.10 milestone Oct 6, 2025
# Test 2: Barrier with forced settings
settings_forced = SolverSettings()
settings_forced.set_parameter(CUOPT_METHOD, SolverMethod.Barrier)
settings_forced.set_parameter(CUOPT_FOLDING, 1) # Force folding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem can't be used to test folding. As it can't be folded.

Copy link
Collaborator Author

@rgsl888prabhu rgsl888prabhu Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-maes This test is more towards testing whether API workflow works and there are no gaps. but I am happy to make changes to this test to use other bigger problems, can you please suggest a mps file that I can use to test this ?

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test f13d140

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test 0b97621

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test 373a59b

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test ffca33f

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test cd979cf

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test 93d013a

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test 668ded7

Copy link
Contributor

@chris-maes chris-maes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test f50b7b1

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test 5d56842

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test b6a7ad5

@rgsl888prabhu
Copy link
Collaborator Author

/merge

1 similar comment
@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit b6163c9 into NVIDIA:branch-25.10 Oct 10, 2025
341 of 346 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants